Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly exits whole application during long puts to a slow server #49

Closed
karjaneth opened this issue Feb 7, 2018 · 4 comments
Closed
Labels
more info More details required. Waiting on additional information from OP

Comments

@karjaneth
Copy link

While I'm having a really hard time nailing down the exact conditions under which this happens, it seems that when puting a lot of large files to a fairly slow server, the application using the client will just exit with no error. No exceptions are thrown, no promises are rejected, it doesn't "crash" per-se, and the exit code is always 0, but it does just exit with no warning.

Code following the put is not run, and the last thing I can do is see the exit code if I have a process.on('exit') handler. It's as if something in the library is calling process.exit(0) (which doesn't seem to be the case) or unrefing every callback (I don't know enough about node internals to know if that's possible) or something else?

Providing a debug function to the connect function seems to sometimes show the server disconnecting right before the application exits, but even then it should throw an error, not silently exit the whole node process. The symptoms are similar to this node issue from six years ago, but that has clearly been fixed.

Anyway I'm struggling to get to the bottom of this or even to reproduce it consistently; I can't see any glaring issues in the put implementation. If anyone else can see what the cause of this could be, maybe we can get it fixed in this library.

@vkarpov15
Copy link

@karjaneth did you end up finding a solution for this? I'm scratching my head trying to figure this out now as well, even stubbed out process.exit().

@karjaneth
Copy link
Author

No I never did. It got "resolved" for us when the server in question was made to be faster/more responsive, but this problem was never dealt with. If you figure it out, please share :)

@theophilusx theophilusx added the more info More details required. Waiting on additional information from OP label Aug 22, 2019
@theophilusx
Copy link
Owner

There have been sifnificant changes made in this module since this issue was originally raised. Is it still an issue with latest version e.g. 2.5.2? If not, I would like to close this issue. If it is, then some sample code would help me in being able to reproduce it for further investigation.

@vkarpov15
Copy link

I wasn't able to consistently repro this, but it seems to have gone away after we upgraded from node 6 to node 8. No objections to closing this from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info More details required. Waiting on additional information from OP
Projects
None yet
Development

No branches or pull requests

3 participants