Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Indexer for NZBKing.com and beta.nzbindex.com #960

Closed
wants to merge 1 commit into from
Closed

Added Indexer for NZBKing.com and beta.nzbindex.com #960

wants to merge 1 commit into from

Conversation

danielkastner
Copy link
Contributor

Added Indexer for NZBKing.com (https://www.nzbking.com/; based on Code for Binsearch) and NZBIndex.com's BETA Site (https://beta.nzbindex.com/search)

@theotherp
Copy link
Owner

The first proper backend pull request in nearly six years! Whooo!

I'll try to take a look as soon as possible to give it the recognition it deserves ;-)

@theotherp
Copy link
Owner

Well done!

I fixed some things, namely:

  • Frontend resources are located in core/ui-src and are compiled into the static folder. But the tooling is a hassle to get working and your changes were minimal enough that this wasn't a problem
  • NzbIndex actually supports paging
  • I fixed the maxage parameter for NzbIndex and made it always sort by age desc
  • Improved the size detection for nzbindex
  • The connection check didn't work for nzbindex because it returns a 307 for the main page

I'll close this PR because I merged it into another branch but thanks again.

@theotherp theotherp closed this Aug 10, 2024
theotherp added a commit that referenced this pull request Aug 10, 2024
@John-Gee
Copy link

@theotherp you may want to add OP as an author to your commit. ;)

theotherp added a commit that referenced this pull request Aug 11, 2024
Co-authored-by: Daniel Kastner <daniel@daniel-kastner.ch>

See #960
@theotherp
Copy link
Owner

OP is still in the history of the files as the original contributor. His commit just didn't close this issue.

43cf2cf

But I didn't know about the co-author thing and added him.

@danielkastner
Copy link
Contributor Author

Thanks for accepting my contribution and this project in general. Looking forward to the next release

@danielkastner danielkastner deleted the add-nzbking-and-nzbindexbeta branch August 11, 2024 06:20
@theotherp
Copy link
Owner

@albino1
Copy link

albino1 commented Aug 14, 2024

I wonder if this can be improved at all. Maybe it could automatically filter the visible results to ones that contain the words in your search? I like the idea of begin able to search NZBKing, but the amount of absolutely irrelevant trash and questionable content is incredible. For example, searching for walking dead s01e01 looks like this:

king

And that's a good result. A lot of the time it's questionably legal porn or much, much, worse.

I'm not entirely sure how it generates the results, like is there a file called walking dead s01e01 inside of a video game NZB? Or it just matching one of those keywords and not all of them?

Right now you can just paste your search query into the results filter box, but I think it might make more sense to just effectively do that for NZBKing automatically for the user, which would then return results that look like this instead:

king2

@theotherp
Copy link
Owner

I'll look into it. I already do that in many cases, not sure where it doesn't happen here.

But the quality of the results was one reason why I didn't want to implement it in the first place.

@albino1
Copy link

albino1 commented Aug 15, 2024

I noticed that the Indexer Status always says there are 0 results (which is often correct) but then it still displays sometimes hundreds of results. I'm sure you already fixed it, but I thought I would mention it in case it's related to why there's so many junk results.

king1b

king1

king2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants