Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single block mode on block lists #352

Open
sussexrick opened this issue Oct 31, 2024 · 0 comments
Open

Support single block mode on block lists #352

sussexrick opened this issue Oct 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sussexrick
Copy link
Contributor

If a single block mode is enabled on a block list data type, the ModelsBuilder model will be an instance of BlockListItem<GovUkNotificationBanner, GovUkNotificationBannerSettings> (assuming the configured block type is a notification banner).

This is not an overridable model and not compatible with the partial view we render components with.

The ModelsBuilder model for a block list without single block mode is made overridable by OverridableBlockListPropertyValueConverter.cs so it is likely that the support would need to be added here.

However this could only ever return some generic interface because this property value converter has no knowledge of GovUkNotificationBanner or GovUkNotificationBannerSettings so it might also require another property value converter in GovUk.Frontend.Umbraco that inherits the one above and does more. There may also be impacts elsewhere, eg on the partial views that render components.

@sussexrick sussexrick added the enhancement New feature or request label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant