You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you host all your code in one web project, the current setup is fine.
If you have a larger solution with code separated into multiple Visual Studio projects (typically Razor Class libraries) that are brought together into one web project at build or deploy time, then those separated projects always have GOV.UK uSync files, SASS files and wwwroot files that they don't want.
This might be resolved by:
analysing the code that's referenced in this scenario, and finding a way to move it to the DLL-only ThePensionsRegulator.Umbraco project; or
adding an MSBuild switch that can prevent the unwanted files being copied to the project at build time.
The text was updated successfully, but these errors were encountered:
We already have a core library which is the ThePensionsRegulator.Umbraco package. It only has types in it that are purely about Umbraco though, nothing to do with GOV.UK or TPR. Nonetheless it does cover one of your scenarios, which I'll flag on the relevant PR.
You might want the SASS files, because they're variables and mixins intended to be used in the SASS code for your Razor class libraries, but it could be that you only get them if you have a 'Styles' folder.
I agree uSync files and App_Plugins wouldn't be needed, but that could be excluded using the approach above.
wwwroot might be trickier, because there could be a wwwroot folder without you wanting the files from the package. We could potentially look for the <AddRazorSupportForMvc>true</AddRazorSupportForMvc> property of razor class libraries to determine whether to copy.
If you host all your code in one web project, the current setup is fine.
If you have a larger solution with code separated into multiple Visual Studio projects (typically Razor Class libraries) that are brought together into one web project at build or deploy time, then those separated projects always have GOV.UK uSync files, SASS files and wwwroot files that they don't want.
This might be resolved by:
ThePensionsRegulator.Umbraco
project; orThe text was updated successfully, but these errors were encountered: