Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OIDC ? #104

Open
lucifer-crybaby opened this issue Oct 3, 2022 · 7 comments
Open

Support for OIDC ? #104

lucifer-crybaby opened this issue Oct 3, 2022 · 7 comments

Comments

@lucifer-crybaby
Copy link

Hi, I was able to integrate this bundle into my symfony project and somehow managed to get this working, clients can authorize and get access token and now I got stuck on how to configure userInfo endpoint (I'm using this package as a OIDC) any help ?

@chalasr
Copy link
Member

chalasr commented Oct 6, 2022

This is something that needs to be done. Any contribution is welcome (could be "just" sharing what you did to achieve in this issue or even coming up with a PR). Once we get something satisfying, part of that logic should end up being moved to the oauth2-server library.

@marcriemer
Copy link

marcriemer commented Nov 24, 2022

I started with this. Well others started, but now I will finish it.

Right now you can just overwrite the 5th argument (the default response) with a IdTokenResponse service (CompilerPassInterface). The IdTokenResponse is basically adding an id_token parameter on an openid scope.

https://symfony.com/doc/current/service_container/compiler_passes.html.
https://github.com/marcriemer/oauth2-server

Implementation for the bundle will follow soon.

@dpfaffenbauer
Copy link

@marcriemer what is the status with your implementation? is it ready?

@simondaigre
Copy link

@chalasr Could you check this PR ? Any help wanted to finish this ?

@chalasr
Copy link
Member

chalasr commented Aug 28, 2023

@simondaigre Which PR? Happy to do so but AFAIK nothing's been submitted yet :)

@simondaigre
Copy link

simondaigre commented Aug 28, 2023

@simondaigre Which PR? Happy to do so but AFAIK nothing's been submitted yet :)

Indeed, sorry !

@marcriemer
Copy link

@marcriemer what is the status with your implementation? is it ready?

Still waiting for my pull request to be merged into oauth2-server.

thephpleague/oauth2-server#1316

The IdTokenResponse implementation and oauth2-server-bundle compatibility for 9.x are required to complete OIDC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants