Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to protected method Omnipay\Common\AbstractGateway::setParameter() #217

Closed
mattsah opened this issue Apr 21, 2020 · 4 comments · Fixed by #220
Closed

Call to protected method Omnipay\Common\AbstractGateway::setParameter() #217

mattsah opened this issue Apr 21, 2020 · 4 comments · Fixed by #220

Comments

@mattsah
Copy link

mattsah commented Apr 21, 2020

In 3.0.2 setParameter is a public method on the AbstractGateway -- in 3.0.3 this method appears to be protected via ParametersTrait.

This breaks backwards compatibility.
@kevin-jones
Copy link

Any update on this? We've had to lock our projects to 3.0.2 now and cannot upgrade until this is resolved.

@tobelyan
Copy link

tobelyan commented Jun 1, 2020

Also facing this issue. Locked to version 3.0.2

@barryvdh barryvdh mentioned this issue Jun 2, 2020
Merged
@barryvdh
Copy link
Member

barryvdh commented Jun 2, 2020

I think this should solve it: #220

@barryvdh
Copy link
Member

barryvdh commented Jun 2, 2020

Tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make set/getParameter public on Gateway thephpleague/omnipay-common
4 participants
@mattsah @barryvdh @kevin-jones @tobelyan