Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcases to peridot #174

Closed
ipranjal opened this issue Nov 29, 2017 · 3 comments
Closed

Testcases to peridot #174

ipranjal opened this issue Nov 29, 2017 · 3 comments
Milestone

Comments

@ipranjal
Copy link

saw @ragboyjr comment on pull request #157 , hence was tempted to try peridot I really liked it.
Assuming rewriting test cases is part of #166 I would like to volunteer in writing tests on peridot. @ragboyjr how and where should I start with ?

PS: I opened this issue to keep track of all pull request related to rewriting tests

@ragboyjr
Copy link
Contributor

Well, v4 is a complete rewrite, not much is the same, but i'll stub out some tests for you so you can contribute, wouldn't mind the help :).

Once i get them stubbed, we can just call out in here which tests someone is working on so that we don't overlap. I was doing a good job doing TDD and testing as I develop, but i had to go through several iterations of design which made me want to test after i finished the design.

@ragboyjr
Copy link
Contributor

ragboyjr commented Nov 29, 2017

@physcocode ok, i've made pending tests for everything. We are using peridot/leo for the assertion library and eloquent/phony for the mocking library.

Just call out in this ticket which ones you'll be working on. I'd start with only one or two, and i'm fairly picky about my code so don't take it personally if i have a lot of PR review comments :). Thanks again for the help!

@ragboyjr
Copy link
Contributor

p.s. I just use make test to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants