Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring > upgrade the current monitor to a batching monitor #13

Closed
junhuif opened this issue May 21, 2018 · 2 comments · Fixed by #25
Closed

Monitoring > upgrade the current monitor to a batching monitor #13

junhuif opened this issue May 21, 2018 · 2 comments · Fixed by #25
Assignees
@lifenod
Labels
enhancement

Comments

@junhuif
Copy link
Member

junhuif commented May 21, 2018

From: #12 (review)

At the moment, each data point is sent in a single request, right? So with lots of requests, the monitor will make lots of requests to InfluxDB.

This can be changed so that points are "batched" into a queue, and then a worker sends the queue to InfluxDB after P points, or after S seconds.
@junhuif junhuif mentioned this issue May 21, 2018
Merged
@junhuif junhuif self-assigned this May 22, 2018
@lifenod
Copy link
Contributor

lifenod commented Dec 25, 2018

haha the InfluxDB is very busy https://github.com/theplant/performance/blob/ad1ee830151d9db8955690a316f9d0a236747dad/aigle/units/page-all-pricedown/prod-2018-12-24-reports/README.md

@lifenod lifenod self-assigned this Dec 25, 2018
@lifenod
Copy link
Contributor

lifenod commented Dec 27, 2018

@junhuif I'm working on it.

@junhuif junhuif removed their assignment Dec 27, 2018
@lifenod lifenod mentioned this issue Dec 27, 2018
Closed
@lifenod lifenod mentioned this issue Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifenod lifenod

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Monitor batch write theplant/appkit
2 participants
@junhuif @lifenod