The last person will never get a feedback from the current round

[anapaulagomes]

https://github.com/Thermondo/stanley/blob/ebfdf01e97d465594dfd07e49e4c7fc276c57c56/stanley/helpers.py#L61-L63

All members but the sender will be able to receive feedback.

[anapaulagomes]

I wrote this test to reproduce this behavior:

def test_feedback_round(slack_api_call_mock, slack_post_message_mock):
    sender_receiver_pattern = re.compile(r'\@\w+')
    senders = []
    receivers = []

    def ask_feedback():
        request_feedback()
        call_args = str(slack_post_message_mock.call_args)
        sender, receiver = re.findall(sender_receiver_pattern, call_args)

        assert sender != receiver

        senders.append(sender)
        receivers.append(receiver)

    # since we have 4 members, each one should give/receive feedback 
    # 3 times (12 in a full round)
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()
    ask_feedback()

    assert len(senders) == 12
    assert len(receivers) == 12

    for sender in set(senders):
        assert senders.count(sender) == 3

    for receiver in set(receivers):
        assert receivers.count(receiver) == 3

For correctness, this test should be run many times in a row.