Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pick the version you prefer for Coq 8.20 in Coq Platform 2025.01 #81

Open
MSoegtropIMC opened this issue Dec 5, 2024 · 7 comments

Comments

@MSoegtropIMC
Copy link
Contributor

The Coq team released Coq 8.20.0 on September 3rd, 2024.
The corresponding Coq Platform release 2025.01 should be released before Jan 31st, 2025.
It can be delayed in case of difficulties until Feb 28th, 2025, but this should be an exception.

This issue is to inform you that the opam package we are currently testing in Coq Platform CI works fine with Coq 8.20.0.

Coq Platform CI is currently testing opam package coq-coqprime-generator.1.1.1
from official repository https://coq.inria.fr/opam/released/packages/coq-coqprime-generator/coq-coqprime-generator.1.1.1/opam.

In case this is the version you want to see in Coq Platform, there is nothing to do for you - please just close this issue.

In case you would prefer to see an updated or an older version in the upcoming Coq Platform 2025.01, please inform us as soon as possible and before Dec 31st, 2024!

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.20~2025.01 which already supports Coq version 8.20.0 and contains already working (possibly patched / commit pinned) Coq Platform packages.

In case you want to select a different version, please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#449

@thery thery closed this as completed Dec 18, 2024
@MSoegtropIMC
Copy link
Contributor Author

@thery : I just wanted to ask if this is correct. The package for coq-prime-generator seems to be really old. First it is version 1.1.1 but there is also a tag 1.2.0. Besides the opam package for coq-prime-generator.1.1.1 actually points to:

https://github.com/thery/coqprime/archive/v8.14.1.tar.gz

I think there was some change in tag handling policy which lead to this confusion. Unless you are sure that this is all as it should be, I would ask you to reopen this ticket and review things then.

@thery
Copy link
Owner

thery commented Jan 16, 2025

@MSoegtropIMC apparently there is an issue with the generator not working with recent version of ocaml (#82). I have tried to fix it with a new opam version (#3295)

@thery thery reopened this Jan 16, 2025
@MSoegtropIMC
Copy link
Contributor Author

Thanks for the heads up!

@MSoegtropIMC
Copy link
Contributor Author

@thery : unfortunately I can't take 1.1.2 since it requires OCaml 5.0. Coq Platform is still OCaml 4.X (for performance reasons). Do you know if this is a hard requirement or if one could make the package OCaml 4.X and 5.X compatible?

I plan to tag Thursday or Friday this week, so time is a bit tight. If you need help with opam or whatever, please let me know.

@thery
Copy link
Owner

thery commented Jan 27, 2025

@MSoegtropIMC I did it only for the generator that clearly did not compile under Ocaml 5. Still I guess it should
work also with 4.X I think. My problem is that I don't know how to test it.
If I just relax this constraint on the opam package, will the CI perform the proper tests?

@MSoegtropIMC
Copy link
Contributor Author

I will test it and report here.

@MSoegtropIMC
Copy link
Contributor Author

@thery : I set the lower bound to OCaml to 4.14.2 (what I tested) and this works. I will update the opam package and Coq Platform to 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants