Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add as const to UnimplementedService definition #239

Open
neko-para opened this issue Nov 4, 2023 · 0 comments
Open

Add as const to UnimplementedService definition #239

neko-para opened this issue Nov 4, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@neko-para
Copy link

With as const the typeof definition would keep the information of each method in type space, so that we can properly calculate on it.

Currently, the value of requestStream and responseStream are automatically widen into boolean.

image

image
@thesayyn thesayyn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thesayyn @neko-para