You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Lately I have worked on topology clean up and enhancements. Before every push I need to make sure no side effect nor unwanted changes are accidentally introduced. Simple changes also required careful check. Sometime quotation or extra , create different results. hard to find.
Current sof-ci supports checkpatch and build. Defintely we need more.
Graph comparison, this is low hanging fruit. We have a tool to generate dot and png. I can compare dot text files and throw an error if diff is found. At least we can keep same graph by this.
Ultimately we need diff *.conf files. I did manually every time and go through line by line. Every change will make some difference in conf file. Some are desired, some are not. I need some input/comment/suggestion for this task.
This is one example from I fixed(#2677) with sof-apl-dmic-a4ch-b2ch.conf comparison.
DMIC is accidentally put(or not removed). Hard to catch this error without comparing conf. May be 1. m4 macro validation task above might help here if we can validate type of parameter.
Describe the bug
Lately I have worked on topology clean up and enhancements. Before every push I need to make sure no side effect nor unwanted changes are accidentally introduced. Simple changes also required careful check. Sometime quotation or extra
,
create different results. hard to find.Current sof-ci supports checkpatch and build. Defintely we need more.
This is one example from I fixed(#2677) with sof-apl-dmic-a4ch-b2ch.conf comparison.
DMIC is accidentally put(or not removed). Hard to catch this error without comparing conf. May be
1. m4 macro validation task
above might help here if we can validate type of parameter.The text was updated successfully, but these errors were encountered: