Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][Zephyr] Move all hw init code from platform_init() to Zephyr #5602

Closed
1 task
Tracked by #5794
kv2019i opened this issue Mar 25, 2022 · 6 comments
Closed
1 task
Tracked by #5794
Labels
enhancement New feature or request Zephyr Issues only observed with Zephyr integrated
Milestone

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Mar 25, 2022

Is your feature request related to a problem? Please describe.
Much of the HW init code is already ignored in Zephyr builds in the Zephyr main() -> sof_main() -> primary_core_init() -> platform_init() code path, but not all. This work should be completed.

Examples like platform_init_hw() must be moved to Zephyr side and not the SOF definition should not be used when building for Zephyr.

This has created multiple problems for unit tests on Zephyr side (like for cAVS SSP driver, FYI @juimonen ).

Update 2023: this doesn't really affect "pure Zephyr" platforms unless we remove platform.h completely, but that's beyond scope of this item. So I filed #7248 to track the general discussion of platform.h fate and let's use this to track existing issues with HW init code in platform_init() or current hybrid platforms:

  • remove HW init from Intel cAVS platform
@kv2019i kv2019i added enhancement New feature or request Zephyr Issues only observed with Zephyr integrated labels Mar 25, 2022
@lenghonglin
Copy link
Contributor

see this #5068 (comment)

@lgirdwood lgirdwood added this to the v2.2 milestone Apr 6, 2022
@lgirdwood
Copy link
Member

Making a v2.2 for Intel platforms. @dbaluta NXP likewise for v2.2 ?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 10, 2023

@dbaluta I don't see any clear overlap in platform/imx8/platform.c where SOF side platform code would be initializing hw that is already handle in Zephyr. IMX8 interrupt handling is one possible item, but I guess this is not overlapping with Zephyr yet (it's really handled on SOF side). Feel free to yet in the task tracking list.

@lgirdwood
Copy link
Member

@juimonen @dbaluta on track for v2.6 ?

@lgirdwood lgirdwood modified the milestones: v2.6, v2.7 May 11, 2023
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jun 20, 2023

With #7702 merged, we can now close this.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Aug 17, 2023

Moving this meta item to v2.8. For v2.7, we completed #7896 and start to be completed for Intel targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Zephyr Issues only observed with Zephyr integrated
Projects
None yet
Development

No branches or pull requests

3 participants