Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cadence codec is dead code in-tree, needs a stub #9292

Closed
andyross opened this issue Jul 9, 2024 · 3 comments
Closed

[BUG] Cadence codec is dead code in-tree, needs a stub #9292

andyross opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working as expected

Comments

@andyross
Copy link
Contributor

andyross commented Jul 9, 2024

The Cadence Codec component is dead code in the tree and not built in CI or via any testing with open source tooling. This means it can't be exercised when APIs change and needs to play catch-up via out-of-tree testing. See for example #9287, which had to be rushed in to implement an API change from #9261 that missed it because nothing built it.

Check out the following kconfigs and the code they gate for examples:

  • CONFIG_DTS_CODEC_STUB
  • CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK
  • CONFIG_COMP_IGO_NR_STUB
  • CONFIG_WAVES_CODEC_STUB
  • CONFIG_COMP_RTNR_STUB
  • CONFIG_MAXIM_DSM_STUB

Then enable the component in app/stub_build_all_ipc3/4.conf file (and/or set it to default =y if CONFIG_COMP_STUBS=y) and CI will pick it up automatically and build it vs. all new changes.

@andyross andyross added the bug Something isn't working as expected label Jul 9, 2024
@dbaluta
Copy link
Collaborator

dbaluta commented Jul 12, 2024

@andyross thanks for creating this. I will take care of it.

@AnneOnciulescu
Copy link
Contributor

@dbaluta please assign me to this.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 29, 2024

@andyross good to close after #9312?

@dbaluta dbaluta closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

4 participants