Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map tree collapsed by default #168

Closed
thetarnav opened this issue Nov 16, 2022 · 1 comment
Closed

Map tree collapsed by default #168

thetarnav opened this issue Nov 16, 2022 · 1 comment
Labels
enhancement New feature or request refactor Improve internal logic—doesn't affect features directly

Comments

@thetarnav
Copy link
Owner

Current approach for mapping the tree splits it by roots and only maps roots that could change. But it maps it all, even if it's not visible by the user.

The problem is that the reactivity structure grows very quickly and it easily becomes impossible to navigate without "jumping to nodes" (eg. by searching or locating it on the page).

Having the structure collapsed by default could offer a couple of benefits, but it probably would mean having to refactor the whole logic, both in the debugger and frontend.
Maybe there is an option to test the ux beforehand.

If rewritten, debugger would have to keep track of expanded nodes, even if they get deleted. Every new added node would be collapsed by default.

This would allow us to walk only the expanded part of the tree, instead of splitting walks by roots.

@thetarnav thetarnav added enhancement New feature or request refactor Improve internal logic—doesn't affect features directly labels Nov 16, 2022
@thetarnav
Copy link
Owner Author

I'm adding additional tree-view modes instead: #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Improve internal logic—doesn't affect features directly
Projects
None yet
Development

No branches or pull requests

1 participant