Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach the debugger in the extension content script #45

Closed
thetarnav opened this issue Aug 4, 2022 · 3 comments
Closed

Attach the debugger in the extension content script #45

thetarnav opened this issue Aug 4, 2022 · 3 comments
Labels
enhancement New feature or request on hold This issue is still being considered—but it's development is postponed.

Comments

@thetarnav
Copy link
Owner

After meging #25 users don't have to wrap their application with <Debugger> components, for it to be tracked.
Because of this, it should be theoretically possible to inject the debugger script (that attaches the debugger into the reactive graph) with the extension's content script.

Runtime npm library will still be available, and useful for some cases—for example configuring or adding babel plugins.

@thetarnav thetarnav added the enhancement New feature or request label Aug 4, 2022
@thetarnav
Copy link
Owner Author

thetarnav commented Aug 4, 2022

Ok, so there is a different problem that I didn't think of—loading the debugger by injecting a script tag effectively loads a second solid runtime on the page.

image

This may be a problem, or maybe it won't—it depends if the debugger at any point will need to interact with the application's solid runtime. For example:

  • when users want to register their own plugin. Or interact in any way with it.
  • when the debugger would need to use some of solid's primitives to get information out of the application graph.

It would be great to be able to just install the extension and that's it, but I think we're stuck with an npm library approach. It's not that bad though.
In the future, we might go in a different direction, that provided a similar experience—there are couple of core solid members that would be happy to add the debugger to solid-start or even solid itself.

@thetarnav thetarnav added the on hold This issue is still being considered—but it's development is postponed. label Aug 4, 2022
@myeon7

This comment was marked as resolved.

@thetarnav
Copy link
Owner Author

I'm closing this for now, as this isn't the direction I'll be going currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold This issue is still being considered—but it's development is postponed.
Projects
None yet
Development

No branches or pull requests

2 participants