Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal value serialization #69

Closed
thetarnav opened this issue Aug 14, 2022 · 1 comment · Fixed by #76
Closed

Signal value serialization #69

thetarnav opened this issue Aug 14, 2022 · 1 comment · Fixed by #76
Assignees
Labels
enhancement New feature or request priority Important issue to focus on currently

Comments

@thetarnav
Copy link
Owner

Signals need to be properly serialized, send, and displayed in the extension panel.
The serialization should consider two different situations:

  • serializing only a small value "preview" — if it's a literal value, send the whole thing, but complex objects could just be displayed as Object or Array or Map.
  • serializing the whole object—when user wants to extend the value and see nested properties.

Serialization should contain the type of the value.

image

image

image

image

image

@thetarnav thetarnav added enhancement New feature or request priority Important issue to focus on currently labels Aug 14, 2022
@thetarnav thetarnav self-assigned this Aug 14, 2022
@thetarnav
Copy link
Owner Author

Partially done in #71 by encoding signal preview values.
The next part will be encoding and displaying nested structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority Important issue to focus on currently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant