Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Calling accept/reject after accept/reject has already been called should throw immediate exception #149

Closed
fresheneesz opened this issue Oct 30, 2014 · 2 comments
Assignees
Milestone

Comments

@fresheneesz
Copy link
Contributor

Right now, I was puzzling over seeing Error: write after end being output and killing my server. Turns out I had a call to reject in an if statement immediately followed by a call to accept. Obviously not correct code, but the issue is that the error wasn't reported in a way I could catch, and somehow ended up killing my server, which was pretty annoying.

So I'm suggesting that accept/reject check something relevant and throw an error output so it can be caught and handled. Thanks!

@fresheneesz
Copy link
Contributor Author

Oh one more note about this, that write after end error wasn't happening before I updated to the new version of this module, so something in there must have changed that caused it. An error should definitely be thrown, but in a different way.

@theturtle32
Copy link
Owner

I'm ok with adding this. Pull requests are always welcomed, of course... 😉

@theturtle32 theturtle32 self-assigned this Nov 18, 2014
@theturtle32 theturtle32 added this to the v1.1.0 milestone Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants