Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] RemoveTargetFromExpires attempts to remove a target from versioned top-level roles #380

Closed
asraa opened this issue Sep 9, 2022 · 0 comments · Fixed by #381
Closed

Comments

@asraa
Copy link
Contributor

asraa commented Sep 9, 2022

In

go-tuf/repo.go

Line 1195 in 61872a3

for metaName := range r.meta {

we will remove a target from all delegated roles. However, the check roles.IsDelegatedTargetsManifest(metaName) will return TRUE on metadata like x.root.json or x.snapshot.json, because it's implementation only checks for exact match on the top-level roles like root.json or .snapshot.json.

I can put out a quick PR for this. It's just annoying because the log outputs that messages when a target was not found in the metadata: [2.root.json] The following target is not present: rekor.0.pub.

go-tuf/repo.go

Line 1226 in 61872a3

fmt.Printf("[%v] The following target is not present: %v\n", metaName, path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant