remove warning when checking if delegation certs have expired #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyazdf
reviewed
Nov 14, 2017
tuf/tuf.go
Outdated
| return err | ||
| } | ||
| logrus.Warnf("error with delegation %s key ID %d: %s", delgRole.Name, keyID, err) | ||
| if err := utils.ValidateCertificate(certFromKey, false); err != nil { |
There was a problem hiding this comment.
can we add a comment about why the false value is ok here?
Can be something like: do not check delegation certificate expiry once accepted, use the TUF role expiry instead
Signed-off-by: Kyle Spiers <kyle@spiers.me>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyle Spiers kyle@spiers.me