Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Notary Signer to be non dumpable in Linux #1327

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

justincormack
Copy link
Contributor

This disables

  • core dumps, which might contain keys
  • ability to ptrace the process which may allow keys to be read

This is not enabled in the debug mode.

Signed-off-by: Justin Cormack justin.cormack@docker.com

This disables
 - core dumps, which might contain keys
 - ability to ptrace the process which may allow keys to be read

This is not enabled in the debug mode.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great stuff.

Copy link
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @justincormack

@cyli cyli merged commit c30d5e3 into notaryproject:master Apr 7, 2018
@justincormack justincormack deleted the no-trace branch April 7, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants