Skip to content

Commit 9f35e93

Browse files
committed
Using decorators for comprehensive testing
Jussi in his comment here: #1391 (comment) proposed using decorators when creating comprehensive testing for metadata serialization. The main problems he pointed out is that: 1) there is a lot of code needed to generate the data for each case 2) the test implementation scales badly when you want to add new cases for your tests, then you would have to add code as well 3) the dictionary format is not visible - we are loading external files and assuming they are not changed and valid In this change, I am using a decorator with an argument that complicates the implementation of the decorator and requires three nested functions, but the advantages are that we are resolving the above three problems: 1) we don't need new code when adding a new test case 2) a small amount of hardcoded data is required for each new test 3) the dictionaries are all in the test module without the need of creating new directories and copying data. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
1 parent 2779954 commit 9f35e93

File tree

1 file changed

+164
-217
lines changed

1 file changed

+164
-217
lines changed

0 commit comments

Comments
 (0)