Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation: do we need a separate DEFAULT_HASH_ALGORITHM config option in TUF? #1613

Closed
MVrachev opened this issue Oct 12, 2021 · 2 comments
Closed

New implementation: do we need a separate DEFAULT_HASH_ALGORITHM config option in TUF? #1613

MVrachev opened this issue Oct 12, 2021 · 2 comments
Labels
backlog Issues to address with priority for current development goals discussion Discussions related to the design, implementation and operation of the project repository Related to the repository implementation

Comments

@MVrachev
Copy link
Collaborator

MVrachev commented Oct 12, 2021 •
edited
Loading

Description of issue or feature request:
In Securesystemslib there is the securesystemslib.hash. DEFAULT_HASH_ALGORITHM configuration option which now is set to "sha256".
The question is whether we need an option like this in TUF rather than relying on Securesystemslib?
If securesystemslib.hash. DEFAULT_HASH_ALGORITHM is changed tomorrow how would this affect us?

Current behavior:
Relly on securesystemslib.hash. DEFAULT_HASH_ALGORITHM config option.

Expected behavior:
To be decided.

Based on Joshua Lock's comment #1605 (comment).
@MVrachev MVrachev added discussion Discussions related to the design, implementation and operation of the project ngclient labels Oct 12, 2021
@MVrachev MVrachev mentioned this issue Oct 12, 2021
Merged
3 tasks
@jku jku added repository Related to the repository implementation backlog Issues to address with priority for current development goals and removed ngclient labels Oct 13, 2021
@jku
Copy link
Member

jku commented Jan 12, 2022

I see no need for this. Either we remove the one use of DEFAULT_HASH_ALGORITHM (and force repository implementation to specify algorithms when creating a new TargetFile) or we continue trusting Securesystemslib to handle our crypto stuff.

@jku
Copy link
Member

jku commented Feb 11, 2022

I'm closing: if there are differing opinions (vs the previous comment) feel free to re-open

@jku jku closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Issues to address with priority for current development goals discussion Discussions related to the design, implementation and operation of the project repository Related to the repository implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jku @MVrachev