-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dict comparisons insensitive to order #1788
Labels
backlog
Issues to address with priority for current development goals
discussion
Discussions related to the design, implementation and operation of the project
Milestone
Comments
MVrachev
added
the
discussion
Discussions related to the design, implementation and operation of the project
label
Jan 21, 2022
It's good to add solve this issue with #1775. |
3 tasks
jku
added
the
backlog
Issues to address with priority for current development goals
label
Jan 26, 2022
I have implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backlog
Issues to address with priority for current development goals
discussion
Discussions related to the design, implementation and operation of the project
Description of issue or feature request:
In #1783 we dropped support for Python 3.6 and inside this pr, we decided to drop
OrderedDict
s as well: e3b267e.The argument was that inside python 3.7+ dictionaries insertion order is preserved: https://docs.python.org/3/whatsnew/3.7.html.
Even though the insertion order is preserved we should keep in mind that there are still differences between
OrderedDict
s and regular dictionaries like when comparing them:The question is:
Is it a problem if we have two dictionaries with data in a different order that are not the same?
If yes we have two solutions:
__eq__
implementations make sure this will happen:or in other words where we are using dictionaries make sure when comparing them that the order makes a difference.
The text was updated successfully, but these errors were encountered: