Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libeatmydata for running tests and installing dependencies under Travis CI #596

Closed
vladimir-v-diaz opened this issue Jan 18, 2018 · 5 comments

Comments

@vladimir-v-diaz
Copy link
Contributor

vladimir-v-diaz commented Jan 18, 2018

Description of issue or feature request:

The integration and unit tests take a while to run under Travis CI. Likewise, installing some of our dependencies have taken ages to complete in the past, but things have fortunately improved on this front. @trishankatdatadog has directed me to an interesting project that can potentially address some of these concerns.

libeatmydata, as in lib-eat-my-data.
https://github.com/stewartsmith/libeatmydata

Debian uses it. I notice some Python projects like Numpy use it, as well.

Current behavior:

Installing packages or running tests happen, slowly.

Expected behavior:

Dependencies are installed and unit tests run, quickly.

@vladimir-v-diaz
Copy link
Contributor Author

vladimir-v-diaz commented Jan 18, 2018

@trishankatdatadog
Thanks for sharing this! The IO issues with running the integration and unit tests have always bothered me.

@trishankatdatadog
Copy link
Member

No problem --- hope it helps!

@MVrachev
Copy link
Collaborator

We have made improvements with the performance of the tests #1096.

Still, if we want to optimize even more we can consider this.
What do you think @trishankatdatadog @joshuagl @lukpueh ?

@trishankatdatadog
Copy link
Member

What do you think @trishankatdatadog @joshuagl @lukpueh ?

As long as our tests can detect failures induced by libeatmydata, this should be a harmless improvement to make. But if our tests run quickly enough now, it's probably not worthwhile, and we can close this, and revisit in the future.

@lukpueh
Copy link
Member

lukpueh commented Sep 28, 2020

+1 closing

@lukpueh lukpueh closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants