Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-tuf doesn't support diamond delegations #381

Open
erickt opened this issue Sep 12, 2022 · 0 comments
Open

rust-tuf doesn't support diamond delegations #381

erickt opened this issue Sep 12, 2022 · 0 comments

Comments

@erickt
Copy link
Collaborator

erickt commented Sep 12, 2022

While writing a delegation builder, I noticed that while we have a test for diamond delegations, it doesn't actually work. Consider this delegation tree:

 targets
 /     \
A       B
 \     /
    D

Where D is signed correctly by B, but not signed correctly by A.

Both Client::lookup_target_description and Client::target_description_with_start_time will visit:

  • targets
  • A
  • D (error, A did not sign D. marking as visited)
  • B
  • skip D since it was already visited.

We need to update these delegations as visited only if we decided the delegation is trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant