Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key object definition is missing keyid_hash_algorithms #99

Closed
jku opened this issue May 26, 2020 · 2 comments
Closed

key object definition is missing keyid_hash_algorithms #99

jku opened this issue May 26, 2020 · 2 comments

Comments

@jku
Copy link
Member

jku commented May 26, 2020

spec says that all keys have the format

  { "keytype" : KEYTYPE,
    "scheme" : SCHEME,
    "keyval" : KEYVAL
  }

this matches the specific key format descriptions and later the examples.

The implementation at the moment looks like this however:

  { "keyid_hash_algorithms" : [ HASH_ALGORITHM, ... ] 
    "keytype" : KEYTYPE,
    "scheme" : SCHEME,
    "keyval" : KEYVAL
  }

where HASH_ALGORITHM is e.g. "sha256","sha512"

@lukpueh
Copy link
Member

lukpueh commented May 27, 2020

Thanks for submitting the issue, @jku! This discrepancy is being discussed in detail in theupdateframework/python-tuf#848.

Please also take a look at TAP 12 (draft), which proposes a new way of dealing with keyids.

@joshuagl
Copy link
Member

I'm closing this issue as keyid_hash_algorithms is explicitly not part of the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants