Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing Duplicate Migrations on the Same Shard for Rails > 5.2 and ar-octopus (0.10.2) #581

Open
prathamesh000777 opened this issue Aug 19, 2023 · 2 comments

Comments

@prathamesh000777
Copy link

prathamesh000777 commented Aug 19, 2023

Issue
Currently for Rails 5.2.6 and ar-octopus (0.10.2) and mysql2 (0.5.5) , the migration process runs multiple times on a given shard due to how shards are fetched and processed. This occurs because the list of shards is obtained using the expression migrations.map(&:shards).flatten.map(&:to_s), resulting in an array of shard names. As a consequence, if a shard has 'n' associated migrations, the migration process will be executed 'n' times on that shard.

Proposed Solution
To address this issue and ensure that migrations are not duplicated on the same shard, we can modify the process as follows:

Instead of directly flattening the migrations.map(&:shards) array, we get unique elements migrations.map(&:shards).uniq.

This approach guarantees that each shard will only appear once in the resulting array, preventing duplicate migrations on the same shard.

Benefits
Improves the efficiency of the migration process by preventing unnecessary repeated migrations on the same shard.

Pull Request with fix: #580

@prathamesh000777
Copy link
Author

prathamesh000777 commented Aug 19, 2023

I have raised a pull request with fix
#580

@prathamesh000777 prathamesh000777 changed the title Preventing Duplicate Migrations on the Same Shard Preventing Duplicate Migrations on the Same Shard for Rails > 5.2 Aug 19, 2023
@prathamesh000777 prathamesh000777 changed the title Preventing Duplicate Migrations on the Same Shard for Rails > 5.2 Preventing Duplicate Migrations on the Same Shard for Rails > 5.2 and ar-octopus (0.10.2) Aug 19, 2023
@prostko
Copy link

prostko commented Dec 11, 2024

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants