Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check and status for c8y mapper on te/ #2274

Closed
3 of 7 tasks
Tracked by #2082
Bravo555 opened this issue Sep 20, 2023 · 3 comments
Closed
3 of 7 tasks
Tracked by #2082

Health check and status for c8y mapper on te/ #2274

Bravo555 opened this issue Sep 20, 2023 · 3 comments
Assignees
Labels
theme:monitoring Theme: Service monitoring and watchdogs
Milestone

Comments

@Bravo555
Copy link
Contributor

Bravo555 commented Sep 20, 2023

The c8y mapper is changed to use health status from the te/+/+/+/+/status/health and health check from te/+/+/+/+/cmd/health/check instead of tedge/health/+ and tedge/health-check topics.

Follow-up tasks:

Feature-related

Cleanup

  • Rewrite sending service startup registration message so there's less boilerplate
  • Clean up ServiceTopicId, EntityTopicId, DeviceTopicId, Service, etc. abstractions
  • fill serviceType default in mapper instead of the store
  • Simplify passing of ancestors to functions which need to know ancestors of the given entity

(new issue(s) will be created for the cleanup tasks)

@Bravo555 Bravo555 changed the title Health check and status for c8y on te/+ (here the topics have to be properly defined) Health check and status for c8y on te/+ Sep 20, 2023
@Bravo555 Bravo555 self-assigned this Sep 20, 2023
@Bravo555 Bravo555 changed the title Health check and status for c8y on te/+ Health check and status for c8y mapper on te/+ Oct 16, 2023
@Bravo555 Bravo555 changed the title Health check and status for c8y mapper on te/+ Health check and status for c8y mapper on te/ Oct 16, 2023
@reubenmiller reubenmiller added this to the 0.13.0 milestone Oct 30, 2023
@Bravo555
Copy link
Contributor Author

Bravo555 commented Nov 2, 2023

Because of the upcoming 0.13 release and all feature-related work has been done, this issue can be closed. A new issue(s) will be created for the remaining clean-up tasks.

@Bravo555 Bravo555 closed this as completed Nov 2, 2023
@Bravo555 Bravo555 removed their assignment Nov 2, 2023
@gligorisaev gligorisaev self-assigned this Nov 6, 2023
@gligorisaev
Copy link
Contributor

QA has thoroughly checked the feature and here are the results:

  • Test for ticket exists in the test suite.
  • tests/RobotFramework/tests/MQTT_health_check/MQTT_health_endpoints.robot
  • tests/RobotFramework/tests/MQTT_health_check/health_tedge-mapper-collectd.robot
  • tests/RobotFramework/tests/cumulocity/service_monitoring/service_monitoring.robot
  • tests/RobotFramework/tests/cumulocity/software_management/software.robot
  • tests/RobotFramework/tests/cumulocity/supported_operations/mapper-publishing-agent-supported-ops.robot
  • tests/RobotFramework/tests/tedge/call_tedge_config_list.robot
  • tests/RobotFramework/tests/tedge_to_te_converter/convert_tedge_topics_to_te_topics.robot
  • tests/RobotFramework/tests/cumulocity/supported_operations/mapper-publishing-agent-supported-ops.robot
  • tests/RobotFramework/tests/tedge/call_tedge_config_list.robot
  • tests/RobotFramework/tests/tedge_to_te_converter/convert_tedge_topics_to_te_topics.robot
  • tests/RobotFramework/tests/tedge_to_te_converter/convert_tedge_topics_to_te_topics.robot
  • tests/RobotFramework/tests/tedge_to_te_converter/convert_tedge_topics_to_te_topics.robot
  • QA has tested the bug and could not reproduce it anymore.

@reubenmiller reubenmiller added the theme:monitoring Theme: Service monitoring and watchdogs label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:monitoring Theme: Service monitoring and watchdogs
Projects
None yet
Development

No branches or pull requests

4 participants