Cumulocity operation failureReason field cannot contain quotes

[jarhodes314]

Is your feature improvement request related to a problem? Please describe.
In #2474, I modified the code to debug print some values in errors that later get turned into failure reasons for operations. I was surprised to discover that the mapper removes quotes from failure reasons when serialising them to SmartREST, so this didn't work as intended.

Describe the solution you'd like
Quotes in the error message should be preserved when they are sent to Cumulocity.

Describe alternatives you've considered

Additional context

[rina23q]

Double quotes in failure reason must be escaped by two double quotes like below.

502,c8y_UploadConfigFile,"contains""double""quote"

This sanitize function escapes double quotes by two double quotes, so maybe our failure reason generation doesn't use this function?

thin-edge.io/crates/core/c8y_api/src/smartrest/message.rs

Lines 37 to 46 in b216239

	pub fn sanitize_for_smartrest(input: Vec<u8>, max_size: usize) -> String {
	String::from_utf8(input)
	.unwrap_or_else(|err| {
	error!("The input contains invalid UTF-8: {err}");
	String::default()
	})
	.chars()
	.filter(|&c| c == '\r' || c == '\n' || c == '\t' || !c.is_control())
	.collect::<String>()
	.replace('"', "\"\"")

[jarhodes314]

@gligorisaev I'm hoping the examples from the robot test changes in https://github.com/thin-edge/thin-edge.io/pull/2493/files are sufficient for you to understand what this change affects in tedge and to reproduce it.

[gligorisaev]

QA has thoroughly checked the feature and here are the results:

• Test for ticket exists in the test suite.
• tests/RobotFramework/tests/cumulocity/configuration/configuration_operation.robot
• tests/RobotFramework/tests/cumulocity/configuration/configuration_with_file_transfer_https.robot
• tests/RobotFramework/tests/cumulocity/log/log_operation.robot
• QA has tested the function and it's functioning according description.