v1.3.0 #9
Merged
v1.3.0 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dirtycajunrice
commented
Sep 21, 2024
dirtycajunrice
commented
- Expose SecretKey->ClientID function from rust and update rust libs
- Create and send analytics for connect, with opt out in settings
- Hide OAuthBrowserWidget from editor and Enhance OAuthBrowserUserWidget with events for custom OAuth UI Scenarios
- Fix White-screen OAuth Scenario in Examples
- Add Custom OAuth Browser Overlay example with Circular Throbber and Back button
- Set world override on Level_Thirdweb for GameMode to help new devs
- Set EditiorCustomVirtualPath on plugin to help data segregation
- Expose FWalletHandle to external access in C++
- Add various helper functions
* Update rust libs * Create and send analytics for connect * Add opt out settings for analytics * various helper functions * Hide slate oauth browser from editor * Enhance oauth browser widget with events for custom oauth solutions
0xFirekeeper
requested changes
Sep 21, 2024
| Request->SetHeader("Content-Type", "application/json"); | ||
| Request->SetHeader("x-sdk-name", "UnrealEngineSDK"); | ||
| Request->SetHeader("x-sdk-os", UGameplayStatics::GetPlatformName()); | ||
| Request->SetHeader("x-sdk-platform", "UnrealEngine"); |
There was a problem hiding this comment.
just "unreal-engine" here
| @@ -62,7 +63,8 @@ bool FWalletHandle::CreateInAppEmailWallet(const FString& Email, FWalletHandle& | |||
| nullptr | |||
| ).AssignResult(Error)) | |||
| { | |||
| Wallet = FWalletHandle(FWalletHandle::InApp, Error); | |||
| Wallet = FWalletHandle(InApp, Error); | |||
| FThirdwebAnalytics::SendConnectEvent(Wallet.ToAddress(), Wallet.GetTypeString()); | |||
There was a problem hiding this comment.
Since we need wallet address will have to wait for it to be actually connected, and it's not always connected upon creation, unlike privatekeywallet/smartwallet
| @@ -83,7 +85,8 @@ bool FWalletHandle::CreateInAppOAuthWallet(const EThirdwebOAuthProvider Provider | |||
| TO_RUST_STRING(ThirdwebUtils::ToString(Provider)) | |||
| ).AssignResult(Error)) | |||
| { | |||
| Wallet = FWalletHandle(FWalletHandle::InApp, Error); | |||
| Wallet = FWalletHandle(InApp, Error); | |||
| FThirdwebAnalytics::SendConnectEvent(Wallet.ToAddress(), Wallet.GetTypeString()); | |||
| @@ -106,7 +109,8 @@ bool FWalletHandle::CreateSmartWallet(const int64 ChainID, const bool bGasless, | |||
| TO_RUST_STRING(AccountOverride) | |||
| ).AssignResult(Error)) | |||
| { | |||
| SmartWallet = FWalletHandle(FWalletHandle::Smart, Error); | |||
| SmartWallet = FWalletHandle(Smart, Error); | |||
| FThirdwebAnalytics::SendConnectEvent(SmartWallet.ToAddress(), SmartWallet.GetTypeString()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.