Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tokenizer to split emoji without space delimiter #113

Open
thisandagain opened this issue Mar 29, 2017 · 1 comment
Open

Allow tokenizer to split emoji without space delimiter #113

thisandagain opened this issue Mar 29, 2017 · 1 comment

Comments

@thisandagain
Copy link
Owner

PR #74 initially incorporated a change which used spliddit's hasPair method to split emoji without a "space" or other delimiter. While useful, this change had fairly serious performance consequences. I think it's worthwhile to include this functionality, but it should be optional.

@thorbert
Copy link
Contributor

I think the mod in PR #74 needs a better implementation anyway. We won't only want to split on surrogate pairs. Sometimes we'll probably want to split when there isn't a pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants