-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with npm link or yarn link #233
Comments
npm link
or yarn link
Per the discussion in #208, I don't see how we can get past this. The only way browserify-shim has available to look up the relevant configuration is by traversing upwards and looking for I would consider a PR letting the user opt in and skip configuration lookup for specific packages, effectively preventing browserify-shim from operating on them. That's a pretty sloppy workaround but I don't see any way we can reasonably support |
Hmm I can see how that's an issue. Just wanted to note that it's a fairly common development pattern, and symlinks are also used by monorepo tooling such as lerna. Seems that some tools such as eslint have figured this out, but I doubt it was easy |
The specific issue here is that:
Something like eslint gets past this because the configuration's presence in |
Browserify passes the original file path to the transform so AFAIK we have no way to get the symlink's path, only the underlying realpath. |
It seems this project is incompatible with
yarn link
andnpm link
. I'm a maintainer forgraphiql
, part of the GraphQL working group, and we have ~9 linked repositories that we have to add an empty and temporary"browserify-shim": {},
entry to in order to build the application across these linkages. Any suggestions on how to make this an easier project for our contributors?The text was updated successfully, but these errors were encountered: