-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide official browser compatible version in the releases #134
Comments
Hi @ray-lothian, Did I understand correctly that you would like to have tld.js bundle both the rules (public suffix) and the source code at once so that it can be versioned. If so, I think it's important to point out that there is a trade-off here that not everyone is willing to take:
Hope that helps, |
Right but there are some cases where an external library may need to be verified later. For instance, in my case, I've just started using this library in my browser extension. Note that browser extensions do not allow remote resources. So anyway I need to download the latest version and pack it with my extension. The problem is that there is no reliable way to check the original library to make sure it is not being modified. This is a requirement that extension reviewers check on each update; https://developer.mozilla.org/en-US/Add-ons/Third_Party_Library_Usage If we have an official bundle then I can point to the particular version and it is really easy for the reviewer to verify. |
I understand. Than I think this is currently not possible with tld.js unfortunately. |
If i understand well, you’d like to reference Tld.js within your package.json and to import it within your extension codebase? Or you’d like to fetch a version with all the dependencies + rules to bundle it within your extension? |
I know that we can use https://wzrd.in/standalone/tldjs, but there is no version control. We need something that is persistent and can be referenced, so that it can be checked in the future (MD5 for instance).
The text was updated successfully, but these errors were encountered: