Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client interface to reqres #5

Open
thomasp85 opened this issue Aug 14, 2017 · 0 comments
Open

Add client interface to reqres #5

thomasp85 opened this issue Aug 14, 2017 · 0 comments

Comments

@thomasp85
Copy link
Owner

Currently reqres is intended for server-side use. All the niceties realted to the Request and Response classes could be nice to have as a wrapper for curl calls as well.

Some considerations:

  • Should it be tacket on to current classes or be a separat (sub)class?
    • If it should be tacked on there need to be a new constructor (this might come eventually if moving broader than rook). Also the read-only nature of the Request class needs to be reconsidered. Also, the 1-to-1 link of the Request and Response classes needs to be lifted somehow.
    • If put in separate (sub)class we might miss the possibility of doing manual redirection on the server
  • The obvious interface will be a send() method in Request that performs a curl call, parses the response and creates a Response object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant