-
-
Notifications
You must be signed in to change notification settings - Fork 185
feat: Start the relayproxy as a unix socket. #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4261 +/- ##
==========================================
- Coverage 84.96% 84.96% -0.01%
==========================================
Files 140 141 +1
Lines 5660 5739 +79
==========================================
+ Hits 4809 4876 +67
- Misses 644 651 +7
- Partials 207 212 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ce60710 to
f7e568e
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant feature by adding support for running the relay proxy as a Unix socket. The configuration has been thoughtfully refactored into a more structured server block, which greatly improves clarity and future extensibility. The implementation is solid, with comprehensive updates to tests and documentation to match the new functionality. I've included a few suggestions to enhance error handling, logging consistency, and the robustness of the tests. Overall, this is an excellent and well-executed contribution.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for starting the relay proxy as a Unix socket, which is a great addition for certain deployment scenarios. The changes include a significant and well-executed refactoring of the configuration structure, moving server-related options under a new server block. Backward compatibility is thoughtfully maintained by using getter methods that handle deprecated fields and issue warnings. The documentation, examples, and Helm charts have been updated accordingly, and comprehensive tests for the new Unix socket functionality have been added. My review includes a couple of suggestions to improve test robustness and make the configuration validation logic more resilient to future changes.
|
|
The CI failing for the Helm Check is normal because we need to release the new version of the relay proxy to make the changes works. |



Description
This PR is here to support starting the relay proxy as a unix socket.
The PR contains a new format for the configuration of the relayproxy.
Moving the
listenoption into aserveroption, allowing to have a more fine grained configuration.Closes issue(s)
Resolve #4244
Checklist
README.mdand/website/docs)