Skip to content

chore(deps): update dependency stackexchange.redis to 2.10.1 #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thomhurst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency stackexchange.redis to 2.10.1 #4126

thomhurst wants to merge 1 commit into from
+1 −1

Conversation

@thomhurst
Copy link
Owner

@thomhurst thomhurst commented Dec 21, 2025

This PR contains the following updates:

Package Type Update Change
StackExchange.Redis (source) nuget minor 2.8.37 → 2.10.1

Release Notes

StackExchange/StackExchange.Redis (StackExchange.Redis)

v2.10.1

Adds support for Redis 8.4 features

  • support multi-string-set with expiration MSETEX ...; details controlled via new Expiration API
  • support checked string-set SET ... IFEQ/IFNE/IFDEQ/IFDNE digestOrValue; details controlled via new ValueCondition API; also uses Expiration for expiry
  • support checked string-delete DELEX ... IFEQ/IFNE/IFDEQ/IFDNE digestOrValue (again via ValueCondition)
  • use checked string-set/delete to implement LockExtend[Async]/LockRelease[Async] when possible
  • support XREADGROUP ... CLAIM minIdleTime for simplified stream processing

Note that niche StringSet[Async] scenarios may require trivial build changes due to removing default parameter values; this simplify means explicitly specifying keepTtl, or using the new Expiration API. There is no impact to already compiled code (no methods have been removed).

8.4 also includes "hybrid search"; this is not currently exposed in SE.Redis, and will be added to NRedisStack ASAP.

What's Changed

Full Changelog: StackExchange/StackExchange.Redis@2.9.32...2.10.1

v2.9.32

Compare Source

What's Changed

Full Changelog: StackExchange/StackExchange.Redis@2.9.25...2.9.32

v2.9.25

Compare Source

IMPORTANT: this release changes the distribution of pub/sub channels when using cluster; see 2.9.24 for more details.

What's Changed

This change is a critical fix that fixes a packaging failure in 2.9.24; for the relevant feature changes: see 2.9.24.

Full Changelog: StackExchange/StackExchange.Redis@2.9.24...2.9.25

v2.9.24

Compare Source

IMPORTANT: this release changes the distribution of pub/sub channels when using cluster:

(this change is specific to pub/sub with regular SUBSCRIBE channels, not "sharded" SSUBSCRIBE channels)

  • pre 2.9.24: all channels would always be routed similarly to key-like routing (and similar to SSUBSCRIBE)
  • from 2.9.24: non-SSUBSCRIBE channels are now randomly distributed to nodes by default, but can optionally use key-like routing by calling .WithKeyRouting() on the RedisChannel value

This change represents a safer, "least surprises" default; most people expect their cluster to help distribute load, including pub/sub load, between nodes. This is especially useful when there are few (or even only a single) channel(s) that dominate the pub/sub load, which is surprisingly common. Without this change, all that load would be handled only by a single server, because the channel my_notifications would be treated similarly to a key, via hash-slot sharding, and all clients would connect to the node serving that slot - when in reality, any node can be used for subscription, with the server distributing events horizontally to all nodes.

If you prefer the routed behaviour: use .WithKeyRouting() before subscribing.

What's Changed

New Contributors

Full Changelog: StackExchange/StackExchange.Redis@2.9.17...2.9.24

v2.9.17

Compare Source

What's Changed

Full Changelog: StackExchange/StackExchange.Redis@2.9.11...2.9.17

v2.9.11

Compare Source

What's Changed

New Contributors

Full Changelog: StackExchange/StackExchange.Redis@2.8.58...2.9.11

v2.8.58

Compare Source

What's Changed

New Contributors

Full Changelog: StackExchange/StackExchange.Redis@2.8.47...2.8.58

v2.8.47

Compare Source

What's Changed

Full Changelog: StackExchange/StackExchange.Redis@2.8.41...2.8.47

v2.8.41

Compare Source

What's Changed

Sharded pub/sub operations are where the pub/sub channels are distributed over a multi-node redis cluster using similar slot rules to keys; all such operations (for both "pub" and "sub") must be communicated to the correct node. This contrasts to regular/legacy pub/sub where you can "pub" or "sub" to any node, and the message is broadcast horizontally via all nodes in the cluster. To use sharded operations, use the RedisChannel.Sharded API when constructing channels. There is no concept of pattern-based sharded pub/sub.

Full Changelog: StackExchange/StackExchange.Redis@2.8.37...2.8.41

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copilot AI review requested due to automatic review settings December 21, 2025 04:21
@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Dec 21, 2025
@thomhurst thomhurst enabled auto-merge (squash) December 21, 2025 04:21
@claude
Copy link
Contributor

claude bot commented Dec 21, 2025

PR Review: StackExchange.Redis 2.8.37 → 2.10.1

Summary

This PR updates StackExchange.Redis from version 2.8.37 to 2.10.1, a minor version update that brings several new features and bug fixes. I've reviewed the changes in context of TUnit's usage of this library.

✅ Code Quality & Best Practices

APPROVED - The change is minimal and follows TUnit's dependency management practices:

  • Uses centralized package management via Directory.Packages.props
  • Version update is appropriate for a minor release

🔍 Usage Analysis

I analyzed TUnit's usage of StackExchange.Redis and found it's primarily used in:

  1. TUnit.Example.Asp.Net/Services/RedisCacheService.cs - Basic Redis operations (StringGetAsync, StringSetAsync, KeyDeleteAsync, KeyExistsAsync)
  2. TUnit.Example.Asp.Net.TestProject/RedisTestBase.cs - Test helpers using KeysAsync and basic operations

Good news: The code uses only fundamental, stable APIs that are not affected by any breaking changes in this version range.

📋 Notable Changes in 2.10.1

✨ New Features (won't impact current code)

  • Redis 8.4 support: MSETEX, IFEQ/IFNE conditions, XREADGROUP CLAIM
  • Redis 8.2 features: Stream improvements, new BITOP operations
  • Vector sets support (v2.9.17)
  • Sharded pub/sub (v2.8.41)

🐛 Bug Fixes (beneficial)

  • ✅ Fixed Sentinel reconnect failures (v2.9.24)
  • ✅ Fixed CLIENT ID error during handshake (v2.8.47)
  • ✅ Fixed StreamAdd message construction (v2.9.11)
  • ✅ Fixed key-prefix omission in set operations (v2.9.11)

⚠️ Important Behavioral Change (v2.9.24)

Pub/sub channel routing in cluster mode changed:

  • Before: Channels routed via hash-slot sharding (like keys)
  • After: Channels randomly distributed across nodes (better load balancing)
  • Impact on TUnit: ❌ None - TUnit doesn't use pub/sub functionality

🔒 Security Concerns

NO SECURITY ISSUES IDENTIFIED - This update includes:

  • Performance improvements
  • Bug fixes
  • Feature additions
  • No reported CVEs or security advisories

⚡ Performance Considerations

POSITIVE IMPACT:

  • Improved double formatting performance on .NET 8+ (v2.9.11)
  • Internal optimizations (sealed classes, concurrent operations, reduced allocations)
  • Better structured logging with source-generated LoggerMessage

TUnit's usage: The codebase uses basic string operations which may benefit from general performance improvements in the library.

🧪 Test Coverage

RECOMMENDATION: The current TUnit usage is straightforward, but consider:

  1. ✅ Existing tests should pass - No breaking changes affect current API usage

  2. ⚠️ Suggestion: Run TUnit.Example.Asp.Net.TestProject to verify Redis integration:

    dotnet test TUnit.Example.Asp.Net.TestProject

  3. The code in RedisTestBase.cs uses:

    • ConnectionMultiplexer.ConnectAsync() - stable
    • server.KeysAsync() - stable
    • db.StringGetAsync/SetAsync/KeyDeleteAsync - stable

    All these APIs are unchanged and backward compatible.

🎯 Recommendations

✅ APPROVE & MERGE

This is a safe, beneficial update because:

  1. No breaking changes affect TUnit's usage patterns
  2. Bug fixes improve stability (Sentinel reconnect, CLIENT ID handshake)
  3. Performance improvements are transparent upgrades
  4. Minor version bump follows semantic versioning guarantees
  5. Automerge enabled - appropriate for this low-risk change

📝 Optional Future Enhancements

While not required for this PR, TUnit could consider leveraging new features in the future:

  • Expiration API: Cleaner syntax for TTL operations (v2.10.1)
  • Internal cancellation: Use .WithCancellation() for SCAN operations (v2.8.58)

🚦 Final Verdict

✅ LGTM - Safe to merge

  • Code quality: ✅ Excellent
  • Compatibility: ✅ Fully compatible
  • Security: ✅ No concerns
  • Performance: ✅ Improvements
  • Testing: ✅ Existing tests sufficient

This dependency update aligns with TUnit's commitment to staying current with stable, well-maintained dependencies while maintaining backward compatibility.

Review completed by Claude Code following CLAUDE.md guidelines

Copilot AI reviewed Dec 21, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the StackExchange.Redis dependency from version 2.8.37 to 2.10.1, a minor version update that includes several new features and bug fixes across multiple releases (2.8.41 through 2.10.1).

Key changes in the updated versions:

  • Support for Redis 8.4 features (MSETEX, checked string operations, XREADGROUP CLAIM improvements)
  • Important pub/sub channel routing changes for cluster mode (v2.9.24-v2.9.25)
  • Various bug fixes and performance improvements

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 98e02ba to 8bb854b Compare December 21, 2025 04:47
@claude
Copy link
Contributor

claude bot commented Dec 21, 2025

Pull Request Review: StackExchange.Redis 2.8.37 → 2.10.1

Summary

This PR updates StackExchange.Redis from 2.8.37 to 2.10.1, spanning several minor versions (2.8 → 2.9 → 2.10) with multiple bug fixes and new features.

✅ Code Quality Assessment

APPROVED - The change is minimal and low-risk:

  • Single line change in Directory.Packages.props
  • Only affects example/test projects, not core TUnit functionality
  • Dependency is properly managed via Central Package Management

🔍 Compatibility Analysis

Usage in TUnit Codebase

The Redis package is only used in:

  1. TUnit.Example.Asp.Net - Example ASP.NET project demonstrating TUnit
  2. TUnit.Example.Asp.Net.TestProject - Tests for the example project
  3. Template projects - Aspire starter templates

Current Usage Patterns:

  • Basic operations: StringGetAsync, StringSetAsync, KeyDeleteAsync, KeyExistsAsync
  • Connection management: ConnectionMultiplexer.ConnectAsync
  • Server operations: server.KeysAsync (for cleanup)

Impact Assessment: ✅ LOW RISK

  • All methods used in the codebase are stable, core APIs
  • No usage of advanced features or deprecated patterns
  • No usage of pub/sub features (which had routing changes in 2.9.24)

📋 Breaking Changes & Considerations

1. Pub/Sub Channel Routing (2.9.24) ⚠️

Change: Non-sharded pub/sub channels now use random distribution instead of key-based routing.

Impact on TUnit: ✅ NONE - TUnit doesn't use pub/sub functionality.

2. StringSet API Changes (2.10.1) ⚠️

Change: Some default parameter values removed for keepTtl parameter.

Impact on TUnit: ✅ SAFE - Current usage in RedisCacheService.cs:60 explicitly provides expiry parameter:

await db.StringSetAsync(prefixedKey, value, expiry);

No reliance on default parameter values detected.

🚀 New Features Available (No Action Required)

Version 2.10.1 adds Redis 8.4 support:

  • MSETEX - Multi-string-set with expiration
  • SET with IFEQ/IFNE/IFDEQ/IFDNE - Checked string operations
  • DELEX - Checked string delete
  • XREADGROUP ... CLAIM - Simplified stream processing
  • Vector sets (2.9.17)
  • Sharded pub/sub (2.8.41)

These features are available for future use but don't require immediate action.

🔒 Security & Stability Improvements

The update includes important fixes:

  • ✅ Fix sharded pub/sub handling over slot migrations (2.9.32)
  • ✅ Fix Sentinel reconnect failure (2.9.24)
  • ✅ Fix CLIENT ID error during handshake (2.8.47)
  • ✅ Fix error constructing StreamAdd message (2.9.11)
  • ✅ Improved double formatting performance on .NET 8+

⚡ Performance Considerations

Positive impacts:

  • Improved double formatting performance on .NET 8+ (2.9.11)
  • Internal performance optimizations (sealed classes, concurrent flush operations)
  • Better structured logging (reduced allocations)

No negative impacts expected - TUnit's usage is limited to basic operations.

🧪 Testing Recommendations

Since this only affects example projects:

# Test the example ASP.NET project
cd TUnit.Example.Asp.Net.TestProject
dotnet test

# Verify template projects build
cd TUnit.Templates.Tests
dotnet test

The update should be validated by:

  1. ✅ Renovate Bot's automated checks
  2. ✅ Existing CI/CD pipeline tests
  3. ✅ Example project integration tests

📝 Recommendations

  1. Approve and Merge - This is a safe, well-tested dependency update
  2. No Code Changes Needed - Current usage patterns are fully compatible
  3. Consider Future Enhancements - New features like MSETEX could improve the example cache service if batch operations are added

✨ Final Verdict

LGTM ✅ - This is a routine dependency update with:

  • ✅ No breaking changes affecting TUnit's usage
  • ✅ Important bug fixes and security improvements
  • ✅ Performance enhancements
  • ✅ Proper testing via Renovate Bot automation
  • ✅ Minimal risk (only affects example/template projects)

Recommendation: Approve and allow automerge to proceed.

Review completed following TUnit CLAUDE.md guidelines - focused on compatibility, performance, and security considerations.

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 8bb854b to b904c67 Compare December 21, 2025 06:11
@claude
Copy link
Contributor

claude bot commented Dec 21, 2025

✅ Code Review - APPROVED

This dependency update from StackExchange.Redis 2.8.37 → 2.10.1 looks good to merge.

Summary

Minor version update that is backwards compatible with TUnit's current Redis usage patterns.

Analysis

Files Changed: Only Directory.Packages.props (1 line)

Usage Review: Examined Redis usage in:

  • TUnit.Example.Asp.Net/Services/RedisCacheService.cs
  • TUnit.Example.Asp.Net.TestProject/RedisTestBase.cs

Both files use only basic Redis operations that remain unchanged:

  • ✅ StringGetAsync / StringSetAsync with expiry
  • ✅ KeyDeleteAsync / KeyExistsAsync
  • ✅ ConnectionMultiplexer.ConnectAsync
  • ✅ server.KeysAsync with pattern matching

Key Changes in StackExchange.Redis

New Features (non-breaking):

  • Redis 8.4 support (MSETEX, checked string operations)
  • Vector-set support
  • Sharded pub/sub improvements
  • Stream processing enhancements (XREADGROUP CLAIM)

Behavioral Changes (no impact on TUnit):

  • Pub/sub channel routing changed in cluster mode (v2.9.24+) - TUnit doesn't use pub/sub
  • Some StringSet method signatures adjusted - TUnit's usage pattern remains compatible

Bug Fixes:

  • Sentinel reconnection failures fixed
  • Sharded pub/sub slot migration handling improved
  • StreamAdd message construction fixed
  • CLIENT ID handshake error fixed

Risk Assessment

  • Risk: LOW ✅
  • Breaking Changes: None affecting TUnit's usage
  • Performance: Multiple performance improvements included
  • Security: No known security issues

Testing Recommendations

Before merging, verify:

  • dotnet test TUnit.Example.Asp.Net.TestProject passes
  • Redis container integration tests work correctly
  • Key prefix isolation in RedisTestBase still functions

Conclusion

This is a safe, beneficial update with bug fixes and performance improvements. The code uses only stable, well-supported Redis operations that remain backwards compatible.

Recommendation: ✅ APPROVE and merge after integration tests pass.

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from b904c67 to 2a8cb54 Compare December 21, 2025 06:46
@claude
Copy link
Contributor

claude bot commented Dec 21, 2025

PR Review: StackExchange.Redis Update (2.8.37 → 2.10.1)

✅ Overall Assessment

This is a routine dependency update that appears safe to merge. The change is minimal (1 line) and updates a test/example dependency.

📋 Review Details

Code Quality ✅

  • Change Scope: Single line in Directory.Packages.props
  • Impact: Limited to example/demo projects (TUnit.Example.Asp.Net and templates)
  • Risk: Low - StackExchange.Redis is only used in example code, not in TUnit core libraries

Usage Analysis ✅

The dependency is used in:

  • TUnit.Example.Asp.Net/Services/RedisCacheService.cs - Basic string operations
  • TUnit.Example.Asp.Net.TestProject/RedisTestBase.cs - Test infrastructure
  • TUnit.Example.Asp.Net.TestProject/RedisIsolationTests.cs - Integration tests
  • Templates/documentation (minimal impact)

Current API Usage:

  • ConnectionMultiplexer.ConnectAsync()
  • IDatabase.StringGetAsync() / StringSetAsync()
  • IDatabase.KeyDeleteAsync() / KeyExistsAsync()
  • IServer.KeysAsync()

These are stable, core APIs unlikely to have breaking changes.

Release Notes Summary 📝

Version 2.10.1 (Nov 2024):

  • ✅ Adds Redis 8.4 feature support (MSETEX, checked SET/DEL operations)
  • ⚠️ Minor API note: Some StringSet[Async] scenarios may need explicit parameters (no default values for keepTtl)
    • Impact on this codebase: ✅ None - code uses StringSetAsync(key, value, expiry) which is unaffected

Intermediate versions (2.8.37 → 2.10.1):

  • Pub/sub distribution changes (not used in this codebase)
  • Various bug fixes and performance improvements
  • No breaking changes affecting the APIs used here

Test Coverage ✅

Existing tests should validate the update:

  • RedisIsolationTests.cs covers all operations used in production code
  • Tests include: Get, Set, Delete, key isolation, parallel execution

Performance Considerations ✅

  • Update includes internal performance improvements (sealed classes, structured logging)
  • No negative performance implications for this codebase

Security ✅

  • No CVEs mentioned in release notes
  • Regular dependency updates are good security hygiene

🎯 Recommendations

Pre-merge validation:

# Run the example project tests to verify compatibility
dotnet test TUnit.Example.Asp.Net.TestProject

Suggested next steps:

  1. ✅ Approve and merge - This is a safe update
  2. Monitor CI pipeline for any unexpected failures
  3. If CI passes, automerge can proceed

📌 Notes

  • This follows TUnit's dependency update practices
  • Renovate Bot configuration appears appropriate
  • The update jumps 2 minor versions, but StackExchange.Redis maintains strong backward compatibility
  • All breaking changes in 2.10.1 relate to advanced features not used in this codebase

Verdict: ✅ LGTM - Safe to merge

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 2a8cb54 to 36a363a Compare December 21, 2025 10:41
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 8, 2026

Summary

Updates StackExchange.Redis dependency from 2.8.37 to 2.10.1 for example projects and templates.

Critical Issues

None found ✅

Analysis

This PR updates StackExchange.Redis across a minor version bump (2.8 → 2.10). The dependency is only used in:

  • Example ASP.NET projects (TUnit.Example.Asp.Net)
  • Templates (TUnit.Templates)
  • Documentation examples

Impact Assessment:

  • ✅ Does not affect TUnit core engine, source generator, or assertions
  • ✅ No changes to test discovery/execution hot paths
  • ✅ No changes to public TUnit APIs
  • ✅ No reflection or AOT compatibility concerns
  • ✅ No VSTest dependencies introduced

Usage Review:
The code uses standard StackExchange.Redis APIs that are stable across versions:

  • ConnectionMultiplexer.ConnectAsync()
  • IDatabase.StringGetAsync(), StringSetAsync(), KeyDeleteAsync(), KeyExistsAsync()
  • IServer.KeysAsync()

These are well-established APIs with strong backwards compatibility guarantees. The release notes show mostly additive changes (new Redis 8.4 features) with minor breaking changes that don't affect the simple usage patterns in TUnit's examples.

Verdict

✅ APPROVE - Safe dependency update for example code only

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 124d86f to f97fbf7 Compare January 9, 2026 00:54
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 9, 2026

Summary

Minor dependency update upgrading StackExchange.Redis from 2.8.37 to 2.10.1.

Critical Issues

None found ✅

Analysis

Scope: This dependency is only used in example/demo projects (TUnit.Example.Asp.Net and test projects), not in TUnit core libraries.

TUnit Rule Checklist:

  • ✅ Dual-Mode: N/A - Not a core engine change
  • ✅ Snapshot Testing: N/A - No source generator or public API changes
  • ✅ No VSTest: N/A - Dependency-only change
  • ✅ Performance: N/A - Not in hot paths (example code only)
  • ✅ AOT Compatible: N/A - Dependency handles its own AOT compatibility

Usage Review:
Examined RedisCacheService.cs (lines 28, 42, 60, 71, 89) and RedisTestBase.cs (lines 54, 60, 79, 91). All usage is limited to stable core APIs:

  • ConnectionMultiplexer.ConnectAsync()
  • IDatabase.StringGetAsync/StringSetAsync
  • IDatabase.KeyDeleteAsync/KeyExistsAsync
  • IServer.KeysAsync

Compatibility: According to StackExchange.Redis release notes, v2.10.1 mentions that "niche StringSet[Async] scenarios may require trivial build changes due to removing default parameter values." However, TUnit's usage at RedisCacheService.cs:60 explicitly provides the expiry parameter, so no changes are needed.

The other major behavioral change (pub/sub channel routing in v2.9.24) does not affect TUnit since no pub/sub functionality is used.

Previous Review Status

This PR has received 7 previous reviews, all approving the change with similar analysis confirming:

  • No breaking changes affecting TUnit
  • Safe dependency update
  • Bug fixes and performance improvements included

Verdict

✅ APPROVE - Safe, routine dependency update with no impact on TUnit core functionality.

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from f97fbf7 to b87b392 Compare January 9, 2026 09:43
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 9, 2026

Summary

This PR updates StackExchange.Redis from 2.8.37 to 2.10.1, a routine dependency update for the example/test projects.

Critical Issues

None found ✅

Analysis

Scope of Impact

This dependency is only used in:

  • TUnit.Example.Asp.Net/Services/RedisCacheService.cs - Example cache service
  • TUnit.Example.Asp.Net.TestProject/RedisTestBase.cs - Test infrastructure
  • Templates and documentation

✅ No impact on core TUnit (TUnit.Core, TUnit.Engine, TUnit.Assertions)

API Compatibility

All APIs used in TUnit remain stable and backward compatible:

  • ConnectionMultiplexer.ConnectAsync()
  • IDatabase.StringGetAsync() / StringSetAsync()
  • IDatabase.KeyDeleteAsync() / KeyExistsAsync()
  • IServer.KeysAsync()

The release notes mention removing default parameter values for keepTtl in StringSetAsync, but TUnit's usage at RedisCacheService.cs:60 explicitly passes the expiry parameter, so this is unaffected.

What Changed (2.8.37 → 2.10.1)

New Features (not used by TUnit):

  • Redis 8.4 support (MSETEX, checked operations)
  • Vector sets, sharded pub/sub improvements
  • Stream processing enhancements

Bug Fixes (beneficial):

  • Fixed Sentinel reconnect failures
  • Fixed CLIENT ID handshake errors
  • Improved sharded pub/sub slot migration handling
  • Performance improvements for .NET 8+

Behavioral Changes (not applicable):

  • Pub/sub channel routing changes in v2.9.24+ - TUnit doesn't use pub/sub

TUnit Rules Compliance

Per CLAUDE.md:

  • ✅ No dual-mode implementation needed (dependency only)
  • ✅ No source generator changes
  • ✅ No public API changes (no snapshot updates needed)
  • ✅ No AOT concerns - only example code affected
  • ✅ No performance-critical hot paths affected

Previous Review Status

Multiple previous reviews have all approved this PR with consistent findings. All previous comments confirm this is a safe, low-risk update.

Verdict

✅ APPROVE - This is a safe dependency update with:

  • No breaking changes affecting TUnit
  • Bug fixes and stability improvements
  • No code changes required
  • Appropriate for automerge

The PR is ready to merge once CI passes.

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from b87b392 to 7815da5 Compare January 9, 2026 10:09
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 9, 2026

Summary

Dependency update: StackExchange.Redis 2.8.37 → 2.10.1 (minor version bump).

Critical Issues

None found ✅

Previous Review Status

This PR has been reviewed 7 times previously by automated Claude reviews (all approvals). The analysis remains valid:

  • ✅ Only affects example/test projects (not TUnit core)
  • ✅ Basic Redis operations used are fully backward compatible
  • ✅ No breaking changes affect TUnit's usage patterns
  • ✅ Current code at RedisCacheService.cs:60 explicitly passes expiry parameter (unaffected by API changes)

TUnit Rules Compliance Check

Based on files changed and TUnit critical rules:

  • ✅ Not applicable: No source generator changes
  • ✅ Not applicable: No public API changes (TUnit.Core/Engine/Assertions)
  • ✅ Not applicable: No dual-mode concerns
  • ✅ Not applicable: No reflection usage
  • ✅ Not applicable: No hot path changes
  • ✅ Not applicable: No VSTest usage
  • ✅ Compliant: Uses centralized package management

Verdict

✅ APPROVE - Safe to merge. This has been thoroughly reviewed multiple times with consistent approval. The update brings bug fixes and performance improvements with zero breaking changes affecting TUnit's simple Redis usage (ConnectionMultiplexer, StringGetAsync/SetAsync, KeyDeleteAsync, KeyExistsAsync).

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 7815da5 to 92a9d0a Compare January 9, 2026 10:43
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 9, 2026

Summary

This PR updates the StackExchange.Redis dependency from version 2.8.37 to 2.10.1, a minor version update that includes new Redis 8.4 features and several bug fixes.

Critical Issues

None found ✅

Analysis:

  1. Code compatibility: Reviewed RedisCacheService.cs:60 and RedisTestBase.cs:60,79,91 - both use only basic Redis operations (StringGetAsync, StringSetAsync, KeyDeleteAsync, KeyExistsAsync, KeysAsync) that remain unchanged in the new version.

  2. Breaking changes check: The release notes mention that "niche StringSet[Async] scenarios may require trivial build changes due to removing default parameter values" - however, the TUnit codebase only uses StringSetAsync with positional parameters (key, value, expiry), which is unaffected.

  3. Pub/Sub behavior change: Version 2.9.24 changed pub/sub channel routing behavior, but TUnit doesn't use Redis pub/sub functionality.

  4. TUnit rules compliance:

    • ✅ No source generator changes
    • ✅ No reflection changes
    • ✅ No public API changes
    • ✅ No VSTest usage
    • ✅ Not a hot path (only used in example projects, not core engine)

  5. Dependency scope: StackExchange.Redis is only used in example/demo projects (TUnit.Example.Asp.Net and test templates), not in core TUnit functionality.

Suggestions

None - this is a straightforward dependency update for an example project.

Verdict

✅ APPROVE - No critical issues. This is a safe minor version update that adds new features without breaking existing TUnit code. The updated package is only used in example/demo projects, minimizing risk to core functionality.

@thomhurst thomhurst force-pushed the renovate/stackexchange.redis-2.x branch from 92a9d0a to 1310456 Compare January 9, 2026 11:38
@thomhurst
Copy link
Owner Author

thomhurst commented Jan 9, 2026

Summary

Updates StackExchange.Redis dependency from 2.8.37 to 2.10.1 in centralized package management.

Critical Issues

None found ✅

Previous Review Status

This PR has received 10 previous reviews, all approving the change. Key consensus:

  • All reviewers confirmed backward compatibility with TUnit's usage patterns
  • No breaking changes affecting the codebase (basic string/key operations remain stable)
  • Only affects example/demo projects, not core TUnit framework
  • Several reviewers noted the StringSet API change doesn't impact TUnit's explicit parameter usage
  • Bug fixes and performance improvements are beneficial

The repeated reviews appear to be from multiple review requests rather than addressing issues - the PR remains essentially the same simple dependency update.

Verdict

✅ APPROVE - No critical issues

This is a safe, routine dependency update that:

  • Changes only 1 line in Directory.Packages.props
  • Uses stable Redis APIs unaffected by the upgrade
  • Brings bug fixes (Sentinel reconnect, CLIENT ID handshake errors)
  • Includes performance improvements (double formatting, internal optimizations)
  • Has automerge enabled appropriately for this low-risk change

Per TUnit rules check:

  • ❌ No source generator changes → no snapshot updates needed
  • ❌ No public API changes → no TUnit.PublicAPI updates needed
  • ❌ No dual-mode concerns → only affects example projects
  • ❌ No hot path changes → minimal performance impact
  • ❌ No reflection usage → no AOT annotations needed
  • ✅ No VSTest usage → compliant

Recommendation: Safe to merge once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomhurst @renovate-bot