Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we use DOMAIN and WHITELIST together? #102

Closed
altano opened this issue Apr 14, 2020 · 4 comments
Closed

Can we use DOMAIN and WHITELIST together? #102

altano opened this issue Apr 14, 2020 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@altano
Copy link

altano commented Apr 14, 2020

Feature Request: if both DOMAIN and WHITELIST are both specified, make it so that a user can pass EITHER to be authorized. I don't think anything else makes sense b/c if you have both set, that is the only possible way you would want the DOMAIN list to be used. I think.

Thanks for the great service btw!

@thomseddon
Copy link
Owner

It's a fair point actually, as you say if people do set both then that is probably the only expected result!

Unfortunately that would be a breaking change, so would need a major version bump - but I think it probably makes sense, perhaps we could add a flag to enable that behaviour in v2 but make that the default in v3

@thomseddon thomseddon added the enhancement New feature or request label Apr 15, 2020
@altano
Copy link
Author

altano commented Apr 16, 2020

Unfortunately that would be a breaking change, so would need a major version bump - but I think it probably makes sense, perhaps we could add a flag to enable that behaviour in v2 but make that the default in v3

That sounds reasonable and would be most appreciated!

@tekand
Copy link

tekand commented May 19, 2020

+1 for this change. I would root for the 2.2 + flag version. Would volunteer for beta testing. :)
Thank you for all your efforts.

@thomseddon
Copy link
Owner

Merged in #106 pending release in 2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants