Supabaseify #1
Merged
Supabaseify #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thorwebdev
commented
Jul 5, 2023
•
thorwebdev
commented
- 🔐 nextauth -> Supabase Auth
- 💽 KV -> Postgres with RLS
swyxio
reviewed
Jul 5, 2023
Comment on lines
-14
to
-34
| export const { | ||
| handlers: { GET, POST }, | ||
| auth, | ||
| CSRF_experimental | ||
| } = NextAuth({ | ||
| providers: [GitHub], | ||
| callbacks: { | ||
| jwt({ token, profile }) { | ||
| if (profile) { | ||
| token.id = profile.id | ||
| token.image = profile.picture | ||
| } | ||
| return token | ||
| }, | ||
| authorized({ auth }) { | ||
| return !!auth?.user | ||
| } | ||
| }, | ||
| pages: { | ||
| signIn: '/sign-in' | ||
| } |
There was a problem hiding this comment.
just to call out a potential issue - these are actual config/UX choices https://github.com/vercel-labs/ai-chatbot/pull/90/files i think you have mostly addressed them (except for the forced signin?) but just proactively calling it out
There was a problem hiding this comment.
Ah interesting, their deployed demo actually allows anonymous conversations without requiring you to log in. But yah, happy to add a middleware based redirect if user isn't logged in, is that your preference?
There was a problem hiding this comment.
Okay, added here with an comment that it's optional: 842803c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.