Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate DOI and ORCID in the client side #233

Closed
ja573 opened this issue May 6, 2021 · 1 comment · Fixed by #249
Closed

Validate DOI and ORCID in the client side #233

ja573 opened this issue May 6, 2021 · 1 comment · Fixed by #249
Assignees
@rhigman
Labels
feature New feature or request
Milestone
v0.5.0

Comments

@ja573
Copy link
Member

ja573 commented May 6, 2021

  1. Add a static button to DOI and ORCID input to reflect the static part of the URLs
  2. Convert value automatically from URL path to full URL (parse URL removing protocol and resource name and prepending the standardised version), e.g.
  3. Parsing errors are reported to the user on input
@ja573 ja573 added the feature New feature or request label May 6, 2021
@ja573 ja573 added this to the v0.4.0 milestone May 6, 2021
This was referenced May 6, 2021
Closed
Closed
@ja573
Copy link
Member Author

ja573 commented May 10, 2021

related: #136

@rhigman rhigman mentioned this issue Jun 3, 2021
Merged
@rhigman rhigman linked a pull request Jun 3, 2021 that will close this issue
Add custom Doi and Orcid structs and use them to warn of parsing errors as user types #249
Merged
@ja573 ja573 modified the milestones: v0.4.0, v0.5.0 Jun 18, 2021
@rhigman rhigman closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhigman rhigman

Labels
feature New feature or request
Projects
None yet
Milestone
v0.5.0
2 participants
@ja573 @rhigman