Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Location editable #324

Closed
vincentwj opened this issue Dec 21, 2021 · 3 comments · Fixed by #620
Closed

Make Location editable #324

vincentwj opened this issue Dec 21, 2021 · 3 comments · Fixed by #620
Assignees
Labels
feature New feature or request

Comments

@vincentwj
Copy link
Member

Describe the bug
You cannot delete/edit a Canonical Location unless you also delete all other Non-Canonical Locations

To Reproduce
Steps to reproduce the behavior:

  1. Go to a specific Work, select a specific Publication with more than one Location,
  2. Try to delete the Canonical Location or to change its landing page or its Full Text URL

Expected behavior
You should be able to delete/edit any of the locations with having to delete all others.

@vincentwj vincentwj added the bug Something isn't working label Dec 21, 2021
@rhigman
Copy link
Member

rhigman commented Jan 4, 2022

This will have to wait until we implement updating (rather than just deleting and re-adding) objects such as locations. A publication cannot be left without a canonical location, so this behaviour is intentional to prevent this from occurring.

@vincentwj
Copy link
Member Author

Understood!

@rhigman
Copy link
Member

rhigman commented Mar 7, 2024

This is becoming more pertinent as Thoth Plus ramps up. Example:

  • Publisher enters canonical location with Full Text URL that points to an HTML page, not a PDF (Consider adding check to Location fullTextUrl field to ensure it points directly to file #439)
  • Thoth Plus then disseminates to some additional platforms on publisher's behalf and adds them as non-canonical locations
  • Thoth Dissemination Service attempts to disseminate to Internet Archive (currently still only monthly) and fails due to the Full Text URL issue
  • Publisher's responsibility to correct canonical location to allow IA resubmission, but this now entails correctly deleting and re-creating additional non-canonical locations not added by them

@brendan-oconnell brendan-oconnell self-assigned this Jul 11, 2024
@brendan-oconnell brendan-oconnell added feature New feature or request and removed bug Something isn't working labels Jul 11, 2024
@brendan-oconnell brendan-oconnell changed the title Can't delete Canonical Location Make Location updatable Jul 11, 2024
@brendan-oconnell brendan-oconnell changed the title Make Location updatable Make Location editable Jul 12, 2024
@brendan-oconnell brendan-oconnell linked a pull request Sep 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants