Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Canonical Location to a Publication is still buggy #639

Closed
vincentwj opened this issue Oct 23, 2024 · 1 comment · Fixed by #640
Closed

Adding Canonical Location to a Publication is still buggy #639

vincentwj opened this issue Oct 23, 2024 · 1 comment · Fixed by #640
Labels
bug Something isn't working

Comments

@vincentwj
Copy link
Member

Describe the bug
Adding a Canonical Location leads to error message "Each publication should have a canonical location"

To Reproduce
Steps to reproduce the behavior:

  1. Go to Edit Publication
  2. Click on Add Location (no previous locations added)
  3. Add Landing Page, Full URL, select Publisher Website, Canonical Location Yes
  4. See error

Expected behavior
The Location to be added without error, since it's the first and canonical

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac OS 14.6.1
  • Browser: Firefox
  • Version: 131.0.2

Additional context
Add any other context about the problem here.

@vincentwj vincentwj added the bug Something isn't working label Oct 23, 2024
@ja573 ja573 linked a pull request Oct 23, 2024 that will close this issue
@rhigman
Copy link
Member

rhigman commented Oct 23, 2024

Thanks for the report. This looks like another instance of the third-party package bug (see e.g. #366) where the value shown in the dropdown (here "Yes", for Canonical) does not actually reflect the true value of the dropdown (here the default value of "No", hence the error on hitting Save).

To be fixed under #640 by changing the default true value of the Canonical dropdown to "Yes".

@ja573 ja573 closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants