Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parentheses deprecations for elixir 1.4 #240

Merged

Conversation

leaexplores
Copy link
Contributor

Elixir 1.4 just released lately 🎉

The parentheses are now recommended for method calls without arguments.

This PR fixes the parts where we had deprecations at various areas like so... (See attached code)

Thanks!

warning: variable "package" does not exist and is being expanded to "package()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:20

warning: variable "deps" does not exist and is being expanded to "deps()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:22

warning: variable "elixirc_paths" does not exist and is being expanded to "elixirc_paths()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:46

warning: variable "elixirc_paths" does not exist and is being expanded to "elixirc_paths()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:47

warning: variable "all_emails" does not exist and is being expanded to "all_emails()", please use parenth
eses to remove the ambiguity or change the variable name
  lib/bamboo/plug/email_preview_plug.ex:38

warning: variable "all_emails" does not exist and is being expanded to "all_emails()", please use parenth
eses to remove the ambiguity or change the variable name
  lib/bamboo/plug/email_preview_plug.ex:41

warning: variable "newest_email" does not exist and is being expanded to "newest_email()", please use par
entheses to remove the ambiguity or change the variable name
  lib/bamboo/plug/email_preview_plug.ex:41

warning: variable "all_emails" does not exist and is being expanded to "all_emails()", please use parenth
eses to remove the ambiguity or change the variable name
  lib/bamboo/plug/email_preview_plug.ex:47

warning: variable "all_emails" does not exist and is being expanded to "all_emails()", please use parenth
eses to remove the ambiguity or change the variable name
  lib/bamboo/plug/email_preview_plug.ex:70

warning: variable "test_process" does not exist and is being expanded to "test_process()", please use par
entheses to remove the ambiguity or change the variable name
  lib/bamboo/adapters/test_adapter.ex:25

warning: variable "verify_phoenix_dep" does not exist and is being expanded to "verify_phoenix_dep()", pl
ease use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/phoenix.ex:105

warning: variable "base_uri" does not exist and is being expanded to "base_uri()", please use parentheses
 to remove the ambiguity or change the variable name
  lib/bamboo/adapters/sendgrid_adapter.ex:64

warning: variable "supervisor_name" does not exist and is being expanded to "supervisor_name()", please u
se parentheses to remove the ambiguity or change the variable name
  lib/bamboo/strategies/task_supervisor_strategy.ex:23

warning: variable "no_halt" does not exist and is being expanded to "no_halt()", please use parentheses t
o remove the ambiguity or change the variable name
  lib/mix/start_email_preview_task.ex:43

warning: variable "iex_running?" does not exist and is being expanded to "iex_running?()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/start_email_preview_task.ex:47

warning: variable "delivered_emails" does not exist and is being expanded to "delivered_emails()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:198

warning: variable "all" does not exist and is being expanded to "all()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/sent_email.ex:91

warning: variable "delivered_emails_as_list" does not exist and is being expanded to "delivered_emails_as_list()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:210

warning: variable "flunk_no_emails_received" does not exist and is being expanded to "flunk_no_emails_received()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:199

warning: variable "rand_id" does not exist and is being expanded to "rand_id()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/sent_email.ex:116

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:247

warning: variable "all" does not exist and is being expanded to "all()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/sent_email.ex:132

warning: variable "delivered_emails" does not exist and is being expanded to "delivered_emails()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:255

warning: variable "refute_timeout" does not exist and is being expanded to "refute_timeout()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:279

warning: variable "refute_timeout" does not exist and is being expanded to "refute_timeout()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:320

warning: variable "using_shared_mode?" does not exist and is being expanded to "using_shared_mode?()", please use parentheses to remove the ambiguity or change the variable name
  lib/bamboo/test.ex:335

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/sent_email_test.exs:79

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/sent_email_test.exs:100

warning: variable "newest_email" does not exist and is being expanded to "newest_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/plug/email_preview_plug_test.exs:29

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/phoenix_test.exs:38

warning: variable "newest_email" does not exist and is being expanded to "newest_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/plug/email_preview_plug_test.exs:30

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/phoenix_test.exs:43

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/phoenix_test.exs:48

warning: variable "oldest_email" does not exist and is being expanded to "oldest_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/plug/email_preview_plug_test.exs:31

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/phoenix_test.exs:53

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/strategies/task_supervisor_strategy_test.exs:13
warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_adapter_test.exs:155

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remo
ve the ambiguity or change the variable name
  test/lib/bamboo/adapters/sendgrid_adapter_test.exs:53

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/sendgrid_adapter_test.exs:73

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/email_test.exs:7

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/email_test.exs:58

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/email_test.exs:75

warning: variable "build_config" does not exist and is being expanded to "build_config()", please use par
entheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:16

warning: variable "build_config" does not exist and is being expanded to "build_config()", please use par
entheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:16

warning: variable "assert_no_emails_sent" does not exist and is being expanded to "assert_no_emails_sent(
)", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:79

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remo
ve the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:104

warning: variable "assert_no_emails_delivered" does not exist and is being expanded to "assert_no_emails_
delivered()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:150

warning: variable "assert_no_emails_delivered" does not exist and is being expanded to "assert_no_emails_
delivered()", please use parentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/test_adapter_test.exs:177

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:7

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthes
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:24

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthe$
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:52

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthe$
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:55

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthe$
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:60

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthe$
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mandrill_helper_test.exs:63

warning: variable "get_free_port" does not exist and is being expanded to "get_free_port()", please use $
arentheses to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mailgun_adapter_test.exs:23

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to rem$
ve the ambiguity or change the variable name
  test/lib/bamboo/adapters/mailgun_adapter_test.exs:54

warning: variable "new_email" does not exist and is being expanded to "new_email()", please use parenthe$
es to remove the ambiguity or change the variable name
  test/lib/bamboo/adapters/mailgun_adapter_test.exs:76

@leaexplores leaexplores force-pushed the elixir14-deprecations branch from ec518ec to c173244 Compare January 5, 2017 02:10
@paulcsmith paulcsmith merged commit a41ce9c into beam-community:master Jan 6, 2017
@paulcsmith
Copy link
Contributor

Thank you very much! I really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants