Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and documentation #454

Merged
merged 5 commits into from
Feb 26, 2019
Merged

Fix typos and documentation #454

merged 5 commits into from
Feb 26, 2019

Conversation

maymillerricci
Copy link
Contributor

@maymillerricci maymillerricci commented Feb 26, 2019

Minor fixes including typos and updates to code examples in the README that came up as I was trying to follow along setting up Bamboo.

Includes a typo fix for #449.

@@ -241,13 +241,13 @@ You can use the Bamboo.TestAdapter along with [Bamboo.Test] to make testing your
emails straightforward.

```elixir
# Using the mailer from the Getting Started section
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example really assumes more than the mailer from the Getting Started section, so I think it's better just not to say anything about it.

Copy link
Collaborator

@germsvel germsvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for fixing all of these!

Copy link
Contributor

@jutonz jutonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🍰 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants