Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to bypass list management for SendGridAdapter #458

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Add ability to bypass list management for SendGridAdapter #458

merged 6 commits into from
Mar 5, 2019

Conversation

tomtaylor
Copy link
Contributor

SendGrid offers the option to mark emails as being able to bypass list management (suppression of unsubscribed/bounced emails). This is useful for emails which are compulsory to send, regardless of marketing/personal preferences, like Terms of Service updates, or security notices.

This PR adds a with_bypass_list_management helper to enable this.

maymillerricci
maymillerricci reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple small comments. Thanks for all your work on this!!

lib/bamboo/adapters/send_grid_helper.ex Show resolved Hide resolved
test/lib/bamboo/adapters/sendgrid_helper_test.exs Outdated Show resolved Hide resolved
@tomtaylor
Copy link
Contributor Author

@maymillerricci I've fixed that typo and added some documentation. Hopefully good to go!

maymillerricci
maymillerricci approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Nice! Thanks especially for adding the documentation and for fixing the naming of the send_grid_helper_test file - great catch!

@maymillerricci maymillerricci merged commit a342cb4 into beam-community:master Mar 5, 2019
@tomtaylor tomtaylor mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maymillerricci maymillerricci maymillerricci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomtaylor @maymillerricci