Adding content_id for displaying attachements in HTML email #475
Conversation
|
It says "mix format --check-formatted" failed but gives me no indication of why it fails. |
|
@ttyerl Thanks for this! If you run Also, is there a test we can add for this new behavior? |
…g email_test.exs
|
I ran this locally and everything passed. Not too sure how to fix this failing test. Hints appreciated. |
| } | ||
|
|
||
| @doc ~S""" | ||
| Creates a new Attachment | ||
|
|
||
| context_id can be use to embed an image, attach it and reference in the message body by |
There was a problem hiding this comment.
context_id -> content_id
can be use -> can be used
and reference -> and reference it
|
|
||
| <img src="cid:some-image-cid" alt="img" /> | ||
|
|
||
| within a HTML email message. |
There was a problem hiding this comment.
within a -> within an
| context_id can be use to embed an image, attach it and reference in the message body by | ||
| setting its CID (Content-ID) and using a standard HTML tag: | ||
|
|
||
| <img src="cid:some-image-cid" alt="img" /> |
There was a problem hiding this comment.
I think this needs 2 more spaces of indentation in order to render correctly as code on the docs.
|
|
||
| |> put_html_layout({LayoutView, "email.html"}) | ||
| |> put_attachment(%Bamboo.Attachment{content_type: "image/png", filename: "logo.png", data: get_content(), content_id: "2343333333"}) |
There was a problem hiding this comment.
The code formatter would line the pipes up directly with email - so all the lines are directly in line. Also, what do you think about switching the data passed in in the example to some arbitrary data instead of referencing a get_content() function, to be as understandable as possible?
|
I made these changes and merged in 228827b. |
Adding content_id for displaying attachements in HTML email. The corresponding changes to bamboo_smtp have been made and a PR created for it.