SendGrid Adapter Reply-To parameter updates #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the base Bamboo.Email docs for `put_header/3` the native SMTP header for `Reply-To` is referenced. The SendGridAdapter should also handle and support this standard naming format for the Reply-To header and not just the custom`reply-to` case of the string.
|
Any thoughts on this? |
|
Is this project still maintained by Thoughbot? Should we (users) start maintaining a separate fork? Let us know how we can contribute as things seem to be pretty stagnant here? Just looking to help. |
maymillerricci
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the "native"
Reply-Toheader string (in addition to the already supported customreply-toheader string).Additionally, it also adds full support for SendGrids
reply_toparameter format with both the requiredemailfield and optionalnamefield.I split these two additions into 2 separate commits for easier review and editing. If there is no desire to add full support for the
namefield, I can gladly drop that commit and just send across theReply-Tocommit.To me, at a minimum, the
Reply-Toformat of the header string should be allowed as this is the standard name for the header in SMTP spec and is referenced directly in the top levelBamboo.Emaildocs on theput_header/3function.