Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Mailgun tags and templates #490

Merged
merged 6 commits into from
Jul 26, 2019
Merged

Added support for Mailgun tags and templates #490

merged 6 commits into from
Jul 26, 2019

Conversation

mstratman
Copy link
Contributor

No description provided.

maymillerricci
maymillerricci approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It looks great overall! I just had a few small comments, mostly about code style.

lib/bamboo/adapters/mailgun_helper.ex Outdated Show resolved Hide resolved
lib/bamboo/adapters/mailgun_helper.ex Outdated Show resolved Hide resolved
test/lib/bamboo/adapters/mailgun_helper_test.exs Outdated Show resolved Hide resolved
lib/bamboo/adapters/mailgun_adapter.ex Outdated Show resolved Hide resolved
lib/bamboo/adapters/mailgun_helper.ex Outdated Show resolved Hide resolved
lib/bamboo/adapters/mailgun_helper.ex Outdated Show resolved Hide resolved
@mstratman mstratman mentioned this pull request Jul 19, 2019
Closed
maymillerricci
maymillerricci approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for making those changes! 👍

@maymillerricci maymillerricci merged commit 236b8ce into beam-community:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maymillerricci maymillerricci maymillerricci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstratman @maymillerricci