Collapsed email preview iframe bugfix #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almirsarajcic
changed the title
germsvel
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Wallaby feature test I've needed to read an email, but I could only get iframe element using
Wallaby.Query.css("iframe", visible: false)because the height of the element is 0.I've tried this in multiple versions of Chrome and chromedriver. Also, I've only been able to experience this in headless Chrome in macOS. I wasn't having this issue with Wallaby option
headless: falsenor on a CI instance running Ubuntu.I figured this is not important enough that we should have test for this which adds chromedriver dependency, but I can add it if it's required.
Related to #350 and #351.