Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #580

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Remove deprecated code #580

merged 1 commit into from
Feb 19, 2021

Conversation

germsvel
Copy link
Collaborator

What changed?

We remove deprecated code. In particular, we remove:

  1. Bamboo.Mailer.parse_opts/2. It's been deprecated since commit 584ec63 and people can use build_config/2 instead.

  2. TaskSupervisorStrategy.child_spec/0. That function raises an error to notify people that the supervisor is automatically started and there's no need for setting it up. That change was introduced in 28ca48a and removed from documentation. I think that error can now be removed.

@germsvel germsvel added this to the 2.0 milestone Feb 18, 2021
What changed?
=============

We remove deprecated code. In particular, we remove:

1. `Bamboo.Mailer.parse_opts/2`. It's been deprecated since commit
   [584ec63] and people can use `build_config/2` instead.

2. `TaskSupervisorStrategy.child_spec/0`. That function raises an error
   to notify people that the supervisor is automatically started and
   there's no need for setting it up. That change was introduced in
   [28ca48a] and removed from documentation. I think that error can now
   be removeed.

[584ec63]: 584ec63
[28ca48a]: 28ca48a
@germsvel germsvel merged commit e43a28a into master Feb 19, 2021
@germsvel germsvel deleted the gv-remove-deprecated-code branch February 19, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant